Skip to content

Commit

Permalink
choose a crypto_provider for rustls_cert_gen (#206)
Browse files Browse the repository at this point in the history
From the release 0.12 of rcgen #202
, we must now choose `ring` or `aws_lc_rc` as a feature.
Because `rustls_cert_gen` has `default-features = false`, its build is
currently broken.

This PR activate `aws_lc_rc` feature, because soon it will get RSA key
generation support aws/aws-lc-rs#296 , so it
will provide more options.

But we could also change it to default to whatever `rcgen` default or
use `ring` as default depending on your preferences.
  • Loading branch information
stormshield-gt authored Jan 12, 2024
1 parent 6637060 commit a3831c9
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
15 changes: 15 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,21 @@ jobs:
- name: Run the tests with aws_lc_rs backend enabled
run: cargo test --verbose --no-default-features --features aws_lc_rs,pem --all-targets

# Build rustls-cert-gen as a standalone package, see this PR for why it's needed:
# https://github.com/rustls/rcgen/pull/206#pullrequestreview-1816197358
build-rustls-cert-gen-standalone:
name: Build rustls-cert-gen as a standalone package
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v4
with:
persist-credentials: false
- name: Install rust toolchain
uses: dtolnay/rust-toolchain@stable
- name: Run the tests
run: cargo test --package rustls-cert-gen

coverage:
name: Measure coverage
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion rustls-cert-gen/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ edition.workspace = true
keywords.workspace = true

[dependencies]
rcgen = { path = "../rcgen", default-features = false, features = ["pem"] }
rcgen = { path = "../rcgen", default-features = false, features = ["pem", "ring"] }
bpaf = { version = "0.9.5", features = ["derive"] }
pem = { workspace = true }
ring = { workspace = true }
Expand Down

0 comments on commit a3831c9

Please sign in to comment.