Replies: 1 comment 1 reply
-
Hey Marc, the function itself is private, and it should be simple to get the functionality implemented on the Rust side, after all, Freya is providing all the font managers and the correct order should be resolvable when looking at the source. So though convenient, I don't think this should be part of skia-safe. There are a number of suggestion for more convenient or idiomatic Rust additions, which I personally really like to have (for example #888) and I for myself try to add rudimentary helpers so that the API does not feel completely alien, but thinking this through, and as long there is no clear definition how far this should go, I prefer to add only the absolute necessary ones to remove the maintenance cost and duplication. I am open to hosting another crate that is based on skia-safe under rust-skia that implements such functionality, but only if another maintainer is taking care of it. |
Beta Was this translation helpful? Give feedback.
-
hey Armin!
Having
FontCollection::getFontManagerOrder
would be quite useful considering thatsvg::Dom::from_bytes
now requires passing aFontMgr
.I think it should be easy to implement, right? It would make things a bit easier, as I mainly work with
FontCollection
in Freya. I could try making a PR if you are busy, although I haven't tried compiling Skia in a while.Thoughts ? 👀 😄
Beta Was this translation helpful? Give feedback.
All reactions