Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the error handling for the stdin/err IO thread and exit loop on io::Error #132

Closed
rib opened this issue Oct 16, 2023 · 0 comments · Fixed by #133
Closed

Fix the error handling for the stdin/err IO thread and exit loop on io::Error #132

rib opened this issue Oct 16, 2023 · 0 comments · Fixed by #133

Comments

@rib
Copy link
Collaborator

rib commented Oct 16, 2023 •
edited by MarijnS95
Loading

We should probably drive-by fix the error handling, because this will loop indefinitely as long as read_line() returns an error. For EOF it returns Ok(0) at least 😌

Originally posted by @MarijnS95 in #116 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop log-forwarding thread on IO errors rust-mobile/android-activity
1 participant
@rib