change PR to "waiting on author" after "changes requested" review #1373

[tgross35]

This was requested in #1373 and added in #1379 (cc @mibac138), but it seems like this must have broken at some point.

[ehuss]

Can you say why it does not appear to be working? I tested it locally and it seems to be working for me. Is there a PR that shows an example?

[tgross35]

I just tried it with a handful of PRs in libc and wound up needing to add the label myself, e.g. rust-lang/libc#3962 or rust-lang/libc#3261. An example in rust-lang/rust rust-lang/rust#132939.

[tgross35]

Although it looks like maybe it works at least some of the time? rust-lang/rust#132791

[ehuss]

The feature is not enabled in the libc repository: https://github.com/rust-lang/libc/blob/main/triagebot.toml

See https://forge.rust-lang.org/triagebot/review-submitted.html

[tgross35]

Oh, I assumed it was on by default. Thanks!

[tgross35]

Okay so it's still not working, but something must be wrong with GitHub here. I approved rust-lang/libc#4028 so it should say "approved" on the PR list but it does not:

Additionally, going reviews->approved review shows nothing recent (even though I have been using the approval UI for a while)

Seems this might be a bigger issue https://stackoverflow.com/questions/75637877/github-filtering-not-showing-approved-reviews

[tgross35]

Not sure why this would be, opened a GH bug https://github.com/orgs/community/discussions/144580

[ehuss]

I'm not sure why GitHub is not showing the pulls (maybe because reviews aren't required?). However, I don't think that is related here. I believe the labels weren't changed on rust-lang/libc#4028 because you were not the assignee (that looks to be changed a minute after approving).

[tgross35]

I did try reassigning to myself then reapproving, still no luck - I'll have to wait for a fresh one to roll in and try assigning before I do anything. But I don't think GH requires the assignee be the same as the approver, e.g. here is one in rust-lang/rust where I approved and then assigned to myself rust-lang/rust#132914 and it does show "approved" in the PR list. gh pr view 132914 --repo https://github.com/rust-lang/rust --json reviewDecision also reports "reviewDecision": "APPROVED" for this one, so something seems to be related between reviewDecision and what shows in the PR list.

By extrapolation I am assuming this relates to what triggers triagebot, though I haven't traced back via the REST API I guess triagebot only pays attention to ChangesRequested so approving doesn't do anything. Rustbot still seems to not change labels when I do so, but guess I have some more digging.