From 1d5cfe3a8b8073053299d7810f9348fde1234c15 Mon Sep 17 00:00:00 2001
From: Brad Gibson <b2b@humanenginuity.com>
Date: Mon, 1 Apr 2019 12:08:19 -0700
Subject: [PATCH 1/3] renamed `inner_deref` feature's `deref*()` methods
`as_deref*()` as per discussion
https://github.com/rust-lang/rust/issues/50264
---
src/libcore/option.rs | 8 +--
src/libcore/result.rs | 27 ++++-----
src/libcore/tests/option.rs | 10 ++--
src/libcore/tests/result.rs | 56 +++++++++----------
.../option-as_deref.rs | 6 ++
.../option-as_deref.stderr | 12 ++++
.../option-deref.rs | 6 --
.../option-deref.stderr | 12 ----
.../result-as_deref.rs | 6 ++
...deref-ok.stderr => result-as_deref.stderr} | 8 +--
.../result-as_deref_err.rs | 6 ++
.../result-as_deref_err.stderr | 12 ++++
.../result-as_deref_ok.rs | 6 ++
.../result-as_deref_ok.stderr | 12 ++++
.../result-deref-err.rs | 6 --
.../result-deref-err.stderr | 12 ----
.../result-deref-ok.rs | 6 --
.../result-deref.rs | 6 --
.../result-deref.stderr | 12 ----
19 files changed, 113 insertions(+), 116 deletions(-)
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref.rs
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref.stderr
delete mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/option-deref.rs
delete mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/option-deref.stderr
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref.rs
rename src/test/ui/issues/issue-50264-inner-deref-trait/{result-deref-ok.stderr => result-as_deref.stderr} (57%)
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_err.rs
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_err.stderr
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_ok.rs
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_ok.stderr
delete mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-err.rs
delete mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-err.stderr
delete mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-ok.rs
delete mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-deref.rs
delete mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-deref.stderr
diff --git a/src/libcore/option.rs b/src/libcore/option.rs
index 3da92c0a05ac4..7213acced7f19 100644
--- a/src/libcore/option.rs
+++ b/src/libcore/option.rs
@@ -991,11 +991,11 @@ impl<T: Default> Option<T> {
#[unstable(feature = "inner_deref", reason = "newly added", issue = "50264")]
impl<T: Deref> Option<T> {
- /// Converts from `&Option<T>` to `Option<&T::Target>`.
+ /// Converts from `Option<T>` (or `&Option<T>`) to `Option<&T::Target>`.
///
- /// Leaves the original Option in-place, creating a new one with a reference
- /// to the original one, additionally coercing the contents via `Deref`.
- pub fn deref(&self) -> Option<&T::Target> {
+ /// Leaves the original `Option` in-place, creating a new one containing a reference to the
+ /// inner type's `Deref::Target` type.
+ pub fn as_deref(&self) -> Option<&T::Target> {
self.as_ref().map(|t| t.deref())
}
}
diff --git a/src/libcore/result.rs b/src/libcore/result.rs
index 9b7b83689861b..38b93597d8703 100644
--- a/src/libcore/result.rs
+++ b/src/libcore/result.rs
@@ -927,24 +927,22 @@ impl<T: Default, E> Result<T, E> {
#[unstable(feature = "inner_deref", reason = "newly added", issue = "50264")]
impl<T: Deref, E> Result<T, E> {
- /// Converts from `&Result<T, E>` to `Result<&T::Target, &E>`.
+ /// Converts from `&Result<T, E>` (or `&Result<T, E>`) to `Result<&T::Target, &E>`.
///
- /// Leaves the original Result in-place, creating a new one with a reference
- /// to the original one, additionally coercing the `Ok` arm of the Result via
- /// `Deref`.
- pub fn deref_ok(&self) -> Result<&T::Target, &E> {
+ /// Leaves the original `Result` in-place, creating a new one containing a reference to the
+ /// `Ok` type's `Deref::Target` type.
+ pub fn as_deref_ok(&self) -> Result<&T::Target, &E> {
self.as_ref().map(|t| t.deref())
}
}
#[unstable(feature = "inner_deref", reason = "newly added", issue = "50264")]
impl<T, E: Deref> Result<T, E> {
- /// Converts from `&Result<T, E>` to `Result<&T, &E::Target>`.
+ /// Converts from `&Result<T, E>` (or `&Result<T, E>`) to `Result<&T, &E::Target>`.
///
- /// Leaves the original Result in-place, creating a new one with a reference
- /// to the original one, additionally coercing the `Err` arm of the Result via
- /// `Deref`.
- pub fn deref_err(&self) -> Result<&T, &E::Target>
+ /// Leaves the original `Result` in-place, creating a new one containing a reference to the
+ /// `Err` type's `Deref::Target` type.
+ pub fn as_deref_err(&self) -> Result<&T, &E::Target>
{
self.as_ref().map_err(|e| e.deref())
}
@@ -952,12 +950,11 @@ impl<T, E: Deref> Result<T, E> {
#[unstable(feature = "inner_deref", reason = "newly added", issue = "50264")]
impl<T: Deref, E: Deref> Result<T, E> {
- /// Converts from `&Result<T, E>` to `Result<&T::Target, &E::Target>`.
+ /// Converts from `&Result<T, E>` (or `&Result<T, E>`) to `Result<&T::Target, &E::Target>`.
///
- /// Leaves the original Result in-place, creating a new one with a reference
- /// to the original one, additionally coercing both the `Ok` and `Err` arms
- /// of the Result via `Deref`.
- pub fn deref(&self) -> Result<&T::Target, &E::Target>
+ /// Leaves the original `Result` in-place, creating a new one containing a reference to both
+ /// the `Ok` and `Err` types' `Deref::Target` types.
+ pub fn as_deref(&self) -> Result<&T::Target, &E::Target>
{
self.as_ref().map(|t| t.deref()).map_err(|e| e.deref())
}
diff --git a/src/libcore/tests/option.rs b/src/libcore/tests/option.rs
index b059b134868d9..562fbc8213fb4 100644
--- a/src/libcore/tests/option.rs
+++ b/src/libcore/tests/option.rs
@@ -310,20 +310,20 @@ fn test_try() {
}
#[test]
-fn test_option_deref() {
+fn test_option_as_deref() {
// Some: &Option<T: Deref>::Some(T) -> Option<&T::Deref::Target>::Some(&*T)
let ref_option = &Some(&42);
- assert_eq!(ref_option.deref(), Some(&42));
+ assert_eq!(ref_option.as_deref(), Some(&42));
let ref_option = &Some(String::from("a result"));
- assert_eq!(ref_option.deref(), Some("a result"));
+ assert_eq!(ref_option.as_deref(), Some("a result"));
let ref_option = &Some(vec![1, 2, 3, 4, 5]);
- assert_eq!(ref_option.deref(), Some(&[1, 2, 3, 4, 5][..]));
+ assert_eq!(ref_option.as_deref(), Some(&[1, 2, 3, 4, 5][..]));
// None: &Option<T: Deref>>::None -> None
let ref_option: &Option<&i32> = &None;
- assert_eq!(ref_option.deref(), None);
+ assert_eq!(ref_option.as_deref(), None);
}
#[test]
diff --git a/src/libcore/tests/result.rs b/src/libcore/tests/result.rs
index 1fab07526a07f..5578ef1397e2b 100644
--- a/src/libcore/tests/result.rs
+++ b/src/libcore/tests/result.rs
@@ -225,94 +225,94 @@ fn test_try() {
}
#[test]
-fn test_result_deref() {
- // &Result<T: Deref, E>::Ok(T).deref_ok() ->
+fn test_result_as_deref() {
+ // &Result<T: Deref, E>::Ok(T).as_deref_ok() ->
// Result<&T::Deref::Target, &E>::Ok(&*T)
let ref_ok = &Result::Ok::<&i32, u8>(&42);
let expected_result = Result::Ok::<&i32, &u8>(&42);
- assert_eq!(ref_ok.deref_ok(), expected_result);
+ assert_eq!(ref_ok.as_deref_ok(), expected_result);
let ref_ok = &Result::Ok::<String, u32>(String::from("a result"));
let expected_result = Result::Ok::<&str, &u32>("a result");
- assert_eq!(ref_ok.deref_ok(), expected_result);
+ assert_eq!(ref_ok.as_deref_ok(), expected_result);
let ref_ok = &Result::Ok::<Vec<i32>, u32>(vec![1, 2, 3, 4, 5]);
let expected_result = Result::Ok::<&[i32], &u32>(&[1, 2, 3, 4, 5][..]);
- assert_eq!(ref_ok.deref_ok(), expected_result);
+ assert_eq!(ref_ok.as_deref_ok(), expected_result);
- // &Result<T: Deref, E: Deref>::Ok(T).deref() ->
+ // &Result<T: Deref, E: Deref>::Ok(T).as_deref() ->
// Result<&T::Deref::Target, &E::Deref::Target>::Ok(&*T)
let ref_ok = &Result::Ok::<&i32, &u8>(&42);
let expected_result = Result::Ok::<&i32, &u8>(&42);
- assert_eq!(ref_ok.deref(), expected_result);
+ assert_eq!(ref_ok.as_deref(), expected_result);
let ref_ok = &Result::Ok::<String, &u32>(String::from("a result"));
let expected_result = Result::Ok::<&str, &u32>("a result");
- assert_eq!(ref_ok.deref(), expected_result);
+ assert_eq!(ref_ok.as_deref(), expected_result);
let ref_ok = &Result::Ok::<Vec<i32>, &u32>(vec![1, 2, 3, 4, 5]);
let expected_result = Result::Ok::<&[i32], &u32>(&[1, 2, 3, 4, 5][..]);
- assert_eq!(ref_ok.deref(), expected_result);
+ assert_eq!(ref_ok.as_deref(), expected_result);
- // &Result<T, E: Deref>::Err(T).deref_err() ->
+ // &Result<T, E: Deref>::Err(T).as_deref_err() ->
// Result<&T, &E::Deref::Target>::Err(&*E)
let ref_err = &Result::Err::<u8, &i32>(&41);
let expected_result = Result::Err::<&u8, &i32>(&41);
- assert_eq!(ref_err.deref_err(), expected_result);
+ assert_eq!(ref_err.as_deref_err(), expected_result);
let ref_err = &Result::Err::<u32, String>(String::from("an error"));
let expected_result = Result::Err::<&u32, &str>("an error");
- assert_eq!(ref_err.deref_err(), expected_result);
+ assert_eq!(ref_err.as_deref_err(), expected_result);
let ref_err = &Result::Err::<u32, Vec<i32>>(vec![5, 4, 3, 2, 1]);
let expected_result = Result::Err::<&u32, &[i32]>(&[5, 4, 3, 2, 1][..]);
- assert_eq!(ref_err.deref_err(), expected_result);
+ assert_eq!(ref_err.as_deref_err(), expected_result);
- // &Result<T: Deref, E: Deref>::Err(T).deref_err() ->
+ // &Result<T: Deref, E: Deref>::Err(T).as_deref_err() ->
// Result<&T, &E::Deref::Target>::Err(&*E)
let ref_err = &Result::Err::<&u8, &i32>(&41);
let expected_result = Result::Err::<&u8, &i32>(&41);
- assert_eq!(ref_err.deref(), expected_result);
+ assert_eq!(ref_err.as_deref(), expected_result);
let ref_err = &Result::Err::<&u32, String>(String::from("an error"));
let expected_result = Result::Err::<&u32, &str>("an error");
- assert_eq!(ref_err.deref(), expected_result);
+ assert_eq!(ref_err.as_deref(), expected_result);
let ref_err = &Result::Err::<&u32, Vec<i32>>(vec![5, 4, 3, 2, 1]);
let expected_result = Result::Err::<&u32, &[i32]>(&[5, 4, 3, 2, 1][..]);
- assert_eq!(ref_err.deref(), expected_result);
+ assert_eq!(ref_err.as_deref(), expected_result);
- // The following cases test calling deref_* with the wrong variant (i.e.
- // `deref_ok()` with a `Result::Err()`, or `deref_err()` with a `Result::Ok()`.
- // While unusual, these cases are supported to ensure that an `inner_deref`
+ // The following cases test calling `as_deref_*` with the wrong variant (i.e.
+ // `as_deref_ok()` with a `Result::Err()`, or `as_deref_err()` with a `Result::Ok()`.
+ // While uncommon, these cases are supported to ensure that an `as_deref_*`
// call can still be made even when one of the Result types does not implement
// `Deref` (for example, std::io::Error).
- // &Result<T, E: Deref>::Ok(T).deref_err() ->
+ // &Result<T, E: Deref>::Ok(T).as_deref_err() ->
// Result<&T, &E::Deref::Target>::Ok(&T)
let ref_ok = &Result::Ok::<i32, &u8>(42);
let expected_result = Result::Ok::<&i32, &u8>(&42);
- assert_eq!(ref_ok.deref_err(), expected_result);
+ assert_eq!(ref_ok.as_deref_err(), expected_result);
let ref_ok = &Result::Ok::<&str, &u32>("a result");
let expected_result = Result::Ok::<&&str, &u32>(&"a result");
- assert_eq!(ref_ok.deref_err(), expected_result);
+ assert_eq!(ref_ok.as_deref_err(), expected_result);
let ref_ok = &Result::Ok::<[i32; 5], &u32>([1, 2, 3, 4, 5]);
let expected_result = Result::Ok::<&[i32; 5], &u32>(&[1, 2, 3, 4, 5]);
- assert_eq!(ref_ok.deref_err(), expected_result);
+ assert_eq!(ref_ok.as_deref_err(), expected_result);
- // &Result<T: Deref, E>::Err(E).deref_ok() ->
+ // &Result<T: Deref, E>::Err(E).as_deref_ok() ->
// Result<&T::Deref::Target, &E>::Err(&E)
let ref_err = &Result::Err::<&u8, i32>(41);
let expected_result = Result::Err::<&u8, &i32>(&41);
- assert_eq!(ref_err.deref_ok(), expected_result);
+ assert_eq!(ref_err.as_deref_ok(), expected_result);
let ref_err = &Result::Err::<&u32, &str>("an error");
let expected_result = Result::Err::<&u32, &&str>(&"an error");
- assert_eq!(ref_err.deref_ok(), expected_result);
+ assert_eq!(ref_err.as_deref_ok(), expected_result);
let ref_err = &Result::Err::<&u32, [i32; 5]>([5, 4, 3, 2, 1]);
let expected_result = Result::Err::<&u32, &[i32; 5]>(&[5, 4, 3, 2, 1]);
- assert_eq!(ref_err.deref_ok(), expected_result);
+ assert_eq!(ref_err.as_deref_ok(), expected_result);
}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref.rs b/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref.rs
new file mode 100644
index 0000000000000..67feb3ff6aec3
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref.rs
@@ -0,0 +1,6 @@
+#![feature(inner_deref)]
+
+fn main() {
+ let _result = &Some(42).as_deref();
+//~^ ERROR no method named `as_deref` found for type `std::option::Option<{integer}>`
+}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref.stderr
new file mode 100644
index 0000000000000..ecf6da87c7901
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref.stderr
@@ -0,0 +1,12 @@
+error[E0599]: no method named `as_deref` found for type `std::option::Option<{integer}>` in the current scope
+ --> $DIR/option-as_deref.rs:4:29
+ |
+LL | let _result = &Some(42).as_deref();
+ | ^^^^^^^^
+ |
+ = note: the method `as_deref` exists but the following trait bounds were not satisfied:
+ `{integer} : std::ops::Deref`
+
+error: aborting due to previous error
+
+For more information about this error, try `rustc --explain E0599`.
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/option-deref.rs b/src/test/ui/issues/issue-50264-inner-deref-trait/option-deref.rs
deleted file mode 100644
index f82eafcaffa9a..0000000000000
--- a/src/test/ui/issues/issue-50264-inner-deref-trait/option-deref.rs
+++ /dev/null
@@ -1,6 +0,0 @@
-#![feature(inner_deref)]
-
-fn main() {
- let _result = &Some(42).deref();
-//~^ ERROR no method named `deref` found for type `std::option::Option<{integer}>`
-}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/option-deref.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/option-deref.stderr
deleted file mode 100644
index e916b7d7d3447..0000000000000
--- a/src/test/ui/issues/issue-50264-inner-deref-trait/option-deref.stderr
+++ /dev/null
@@ -1,12 +0,0 @@
-error[E0599]: no method named `deref` found for type `std::option::Option<{integer}>` in the current scope
- --> $DIR/option-deref.rs:4:29
- |
-LL | let _result = &Some(42).deref();
- | ^^^^^
- |
- = note: the method `deref` exists but the following trait bounds were not satisfied:
- `{integer} : std::ops::Deref`
-
-error: aborting due to previous error
-
-For more information about this error, try `rustc --explain E0599`.
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref.rs b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref.rs
new file mode 100644
index 0000000000000..1d5eabd6170b7
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref.rs
@@ -0,0 +1,6 @@
+#![feature(inner_deref)]
+
+fn main() {
+ let _result = &Ok(42).as_deref();
+//~^ ERROR no method named `as_deref` found
+}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-ok.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref.stderr
similarity index 57%
rename from src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-ok.stderr
rename to src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref.stderr
index 593705123540c..2e81d323974a7 100644
--- a/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-ok.stderr
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref.stderr
@@ -1,10 +1,10 @@
-error[E0599]: no method named `deref_ok` found for type `std::result::Result<{integer}, _>` in the current scope
- --> $DIR/result-deref-ok.rs:4:27
+error[E0599]: no method named `as_deref` found for type `std::result::Result<{integer}, _>` in the current scope
+ --> $DIR/result-as_deref.rs:4:27
|
-LL | let _result = &Ok(42).deref_ok();
+LL | let _result = &Ok(42).as_deref();
| ^^^^^^^^
|
- = note: the method `deref_ok` exists but the following trait bounds were not satisfied:
+ = note: the method `as_deref` exists but the following trait bounds were not satisfied:
`{integer} : std::ops::Deref`
error: aborting due to previous error
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_err.rs b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_err.rs
new file mode 100644
index 0000000000000..104aa3bcadff2
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_err.rs
@@ -0,0 +1,6 @@
+#![feature(inner_deref)]
+
+fn main() {
+ let _result = &Err(41).as_deref_err();
+//~^ ERROR no method named `as_deref_err` found
+}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_err.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_err.stderr
new file mode 100644
index 0000000000000..906b9981ddd7b
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_err.stderr
@@ -0,0 +1,12 @@
+error[E0599]: no method named `as_deref_err` found for type `std::result::Result<_, {integer}>` in the current scope
+ --> $DIR/result-as_deref_err.rs:4:28
+ |
+LL | let _result = &Err(41).as_deref_err();
+ | ^^^^^^^^^^^^
+ |
+ = note: the method `as_deref_err` exists but the following trait bounds were not satisfied:
+ `{integer} : std::ops::Deref`
+
+error: aborting due to previous error
+
+For more information about this error, try `rustc --explain E0599`.
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_ok.rs b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_ok.rs
new file mode 100644
index 0000000000000..ebb0500e8190f
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_ok.rs
@@ -0,0 +1,6 @@
+#![feature(inner_deref)]
+
+fn main() {
+ let _result = &Ok(42).as_deref_ok();
+//~^ ERROR no method named `as_deref_ok` found
+}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_ok.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_ok.stderr
new file mode 100644
index 0000000000000..2417efde40d3c
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_ok.stderr
@@ -0,0 +1,12 @@
+error[E0599]: no method named `as_deref_ok` found for type `std::result::Result<{integer}, _>` in the current scope
+ --> $DIR/result-as_deref_ok.rs:4:27
+ |
+LL | let _result = &Ok(42).as_deref_ok();
+ | ^^^^^^^^^^^
+ |
+ = note: the method `as_deref_ok` exists but the following trait bounds were not satisfied:
+ `{integer} : std::ops::Deref`
+
+error: aborting due to previous error
+
+For more information about this error, try `rustc --explain E0599`.
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-err.rs b/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-err.rs
deleted file mode 100644
index 4be2000f058a5..0000000000000
--- a/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-err.rs
+++ /dev/null
@@ -1,6 +0,0 @@
-#![feature(inner_deref)]
-
-fn main() {
- let _result = &Err(41).deref_err();
-//~^ ERROR no method named `deref_err` found
-}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-err.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-err.stderr
deleted file mode 100644
index 333036127eadb..0000000000000
--- a/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-err.stderr
+++ /dev/null
@@ -1,12 +0,0 @@
-error[E0599]: no method named `deref_err` found for type `std::result::Result<_, {integer}>` in the current scope
- --> $DIR/result-deref-err.rs:4:28
- |
-LL | let _result = &Err(41).deref_err();
- | ^^^^^^^^^ help: there is a method with a similar name: `deref_ok`
- |
- = note: the method `deref_err` exists but the following trait bounds were not satisfied:
- `{integer} : std::ops::Deref`
-
-error: aborting due to previous error
-
-For more information about this error, try `rustc --explain E0599`.
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-ok.rs b/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-ok.rs
deleted file mode 100644
index a706cde734805..0000000000000
--- a/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref-ok.rs
+++ /dev/null
@@ -1,6 +0,0 @@
-#![feature(inner_deref)]
-
-fn main() {
- let _result = &Ok(42).deref_ok();
-//~^ ERROR no method named `deref_ok` found
-}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref.rs b/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref.rs
deleted file mode 100644
index 43a68e37dd0c3..0000000000000
--- a/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref.rs
+++ /dev/null
@@ -1,6 +0,0 @@
-#![feature(inner_deref)]
-
-fn main() {
- let _result = &Ok(42).deref();
-//~^ ERROR no method named `deref` found
-}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref.stderr
deleted file mode 100644
index 05baa7907fae0..0000000000000
--- a/src/test/ui/issues/issue-50264-inner-deref-trait/result-deref.stderr
+++ /dev/null
@@ -1,12 +0,0 @@
-error[E0599]: no method named `deref` found for type `std::result::Result<{integer}, _>` in the current scope
- --> $DIR/result-deref.rs:4:27
- |
-LL | let _result = &Ok(42).deref();
- | ^^^^^
- |
- = note: the method `deref` exists but the following trait bounds were not satisfied:
- `{integer} : std::ops::Deref`
-
-error: aborting due to previous error
-
-For more information about this error, try `rustc --explain E0599`.
From d2d1470d0879be19ae5c262896153634b71e68d3 Mon Sep 17 00:00:00 2001
From: Brad Gibson <b2b@humanenginuity.com>
Date: Mon, 1 Apr 2019 12:51:18 -0700
Subject: [PATCH 2/3] added `deref_mut_*` versions of `inner_deref` methods as
per discussion https://github.com/rust-lang/rust/issues/50264
---
src/libcore/option.rs | 13 +-
src/libcore/result.rs | 44 +++++-
src/libcore/tests/option.rs | 22 ++-
src/libcore/tests/result.rs | 129 +++++++++++++++++-
.../option-as_deref.stderr | 2 +-
.../option-as_deref_mut.rs | 6 +
.../option-as_deref_mut.stderr | 12 ++
.../result-as_deref.stderr | 2 +-
.../result-as_deref_err.stderr | 2 +-
.../result-as_deref_mut.rs | 6 +
.../result-as_deref_mut.stderr | 12 ++
.../result-as_deref_mut_err.rs | 6 +
.../result-as_deref_mut_err.stderr | 12 ++
.../result-as_deref_mut_ok.rs | 6 +
.../result-as_deref_mut_ok.stderr | 12 ++
.../result-as_deref_ok.stderr | 2 +-
16 files changed, 274 insertions(+), 14 deletions(-)
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref_mut.rs
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref_mut.stderr
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut.rs
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut.stderr
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_err.rs
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_err.stderr
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_ok.rs
create mode 100644 src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_ok.stderr
diff --git a/src/libcore/option.rs b/src/libcore/option.rs
index 7213acced7f19..bae28c1743631 100644
--- a/src/libcore/option.rs
+++ b/src/libcore/option.rs
@@ -136,7 +136,7 @@
#![stable(feature = "rust1", since = "1.0.0")]
use iter::{FromIterator, FusedIterator, TrustedLen};
-use {hint, mem, ops::{self, Deref}};
+use {hint, mem, ops::{self, Deref, DerefMut}};
use pin::Pin;
// Note that this is not a lang item per se, but it has a hidden dependency on
@@ -1000,6 +1000,17 @@ impl<T: Deref> Option<T> {
}
}
+#[unstable(feature = "inner_deref", reason = "newly added", issue = "50264")]
+impl<T: DerefMut> Option<T> {
+ /// Converts from `Option<T>` (or `&mut Option<T>`) to `Option<&mut T::Target>`.
+ ///
+ /// Leaves the original `Option` in-place, creating a new one containing a mutable reference to
+ /// the inner type's `Deref::Target` type.
+ pub fn as_deref_mut(&mut self) -> Option<&mut T::Target> {
+ self.as_mut().map(|t| t.deref_mut())
+ }
+}
+
impl<T, E> Option<Result<T, E>> {
/// Transposes an `Option` of a `Result` into a `Result` of an `Option`.
///
diff --git a/src/libcore/result.rs b/src/libcore/result.rs
index 38b93597d8703..adb0d0f2408c0 100644
--- a/src/libcore/result.rs
+++ b/src/libcore/result.rs
@@ -232,7 +232,7 @@
use fmt;
use iter::{FromIterator, FusedIterator, TrustedLen};
-use ops::{self, Deref};
+use ops::{self, Deref, DerefMut};
/// `Result` is a type that represents either success ([`Ok`]) or failure ([`Err`]).
///
@@ -927,7 +927,7 @@ impl<T: Default, E> Result<T, E> {
#[unstable(feature = "inner_deref", reason = "newly added", issue = "50264")]
impl<T: Deref, E> Result<T, E> {
- /// Converts from `&Result<T, E>` (or `&Result<T, E>`) to `Result<&T::Target, &E>`.
+ /// Converts from `Result<T, E>` (or `&Result<T, E>`) to `Result<&T::Target, &E>`.
///
/// Leaves the original `Result` in-place, creating a new one containing a reference to the
/// `Ok` type's `Deref::Target` type.
@@ -938,7 +938,7 @@ impl<T: Deref, E> Result<T, E> {
#[unstable(feature = "inner_deref", reason = "newly added", issue = "50264")]
impl<T, E: Deref> Result<T, E> {
- /// Converts from `&Result<T, E>` (or `&Result<T, E>`) to `Result<&T, &E::Target>`.
+ /// Converts from `Result<T, E>` (or `&Result<T, E>`) to `Result<&T, &E::Target>`.
///
/// Leaves the original `Result` in-place, creating a new one containing a reference to the
/// `Err` type's `Deref::Target` type.
@@ -950,7 +950,7 @@ impl<T, E: Deref> Result<T, E> {
#[unstable(feature = "inner_deref", reason = "newly added", issue = "50264")]
impl<T: Deref, E: Deref> Result<T, E> {
- /// Converts from `&Result<T, E>` (or `&Result<T, E>`) to `Result<&T::Target, &E::Target>`.
+ /// Converts from `Result<T, E>` (or `&Result<T, E>`) to `Result<&T::Target, &E::Target>`.
///
/// Leaves the original `Result` in-place, creating a new one containing a reference to both
/// the `Ok` and `Err` types' `Deref::Target` types.
@@ -960,6 +960,42 @@ impl<T: Deref, E: Deref> Result<T, E> {
}
}
+#[unstable(feature = "inner_deref", reason = "newly added", issue = "50264")]
+impl<T: DerefMut, E> Result<T, E> {
+ /// Converts from `Result<T, E>` (or `&mut Result<T, E>`) to `Result<&mut T::Target, &mut E>`.
+ ///
+ /// Leaves the original `Result` in-place, creating a new one containing a mutable reference to
+ /// the `Ok` type's `Deref::Target` type.
+ pub fn as_deref_mut_ok(&mut self) -> Result<&mut T::Target, &mut E> {
+ self.as_mut().map(|t| t.deref_mut())
+ }
+}
+
+#[unstable(feature = "inner_deref", reason = "newly added", issue = "50264")]
+impl<T, E: DerefMut> Result<T, E> {
+ /// Converts from `Result<T, E>` (or `&mut Result<T, E>`) to `Result<&mut T, &mut E::Target>`.
+ ///
+ /// Leaves the original `Result` in-place, creating a new one containing a mutable reference to
+ /// the `Err` type's `Deref::Target` type.
+ pub fn as_deref_mut_err(&mut self) -> Result<&mut T, &mut E::Target>
+ {
+ self.as_mut().map_err(|e| e.deref_mut())
+ }
+}
+
+#[unstable(feature = "inner_deref", reason = "newly added", issue = "50264")]
+impl<T: DerefMut, E: DerefMut> Result<T, E> {
+ /// Converts from `Result<T, E>` (or `&mut Result<T, E>`) to
+ /// `Result<&mut T::Target, &mut E::Target>`.
+ ///
+ /// Leaves the original `Result` in-place, creating a new one containing a mutable reference to
+ /// both the `Ok` and `Err` types' `Deref::Target` types.
+ pub fn as_deref_mut(&mut self) -> Result<&mut T::Target, &mut E::Target>
+ {
+ self.as_mut().map(|t| t.deref_mut()).map_err(|e| e.deref_mut())
+ }
+}
+
impl<T, E> Result<Option<T>, E> {
/// Transposes a `Result` of an `Option` into an `Option` of a `Result`.
///
diff --git a/src/libcore/tests/option.rs b/src/libcore/tests/option.rs
index 562fbc8213fb4..ff43fc49f71e3 100644
--- a/src/libcore/tests/option.rs
+++ b/src/libcore/tests/option.rs
@@ -1,6 +1,8 @@
use core::option::*;
use core::mem;
use core::clone::Clone;
+use core::array::FixedSizeArray;
+use core::ops::DerefMut;
#[test]
fn test_get_ptr() {
@@ -319,13 +321,31 @@ fn test_option_as_deref() {
assert_eq!(ref_option.as_deref(), Some("a result"));
let ref_option = &Some(vec![1, 2, 3, 4, 5]);
- assert_eq!(ref_option.as_deref(), Some(&[1, 2, 3, 4, 5][..]));
+ assert_eq!(ref_option.as_deref(), Some([1, 2, 3, 4, 5].as_slice()));
// None: &Option<T: Deref>>::None -> None
let ref_option: &Option<&i32> = &None;
assert_eq!(ref_option.as_deref(), None);
}
+#[test]
+fn test_option_as_deref_mut() {
+ // Some: &mut Option<T: Deref>::Some(T) -> Option<&mut T::Deref::Target>::Some(&mut *T)
+ let mut val = 42;
+ let ref_option = &mut Some(&mut val);
+ assert_eq!(ref_option.as_deref_mut(), Some(&mut 42));
+
+ let ref_option = &mut Some(String::from("a result"));
+ assert_eq!(ref_option.as_deref_mut(), Some(String::from("a result").deref_mut()));
+
+ let ref_option = &mut Some(vec![1, 2, 3, 4, 5]);
+ assert_eq!(ref_option.as_deref_mut(), Some([1, 2, 3, 4, 5].as_mut_slice()));
+
+ // None: &mut Option<T: Deref>>::None -> None
+ let ref_option: &mut Option<&mut i32> = &mut None;
+ assert_eq!(ref_option.as_deref_mut(), None);
+}
+
#[test]
fn test_replace() {
let mut x = Some(2);
diff --git a/src/libcore/tests/result.rs b/src/libcore/tests/result.rs
index 5578ef1397e2b..163f8d0ab3797 100644
--- a/src/libcore/tests/result.rs
+++ b/src/libcore/tests/result.rs
@@ -1,4 +1,6 @@
use core::option::*;
+use core::array::FixedSizeArray;
+use core::ops::DerefMut;
fn op1() -> Result<isize, &'static str> { Ok(666) }
fn op2() -> Result<isize, &'static str> { Err("sadface") }
@@ -237,7 +239,7 @@ fn test_result_as_deref() {
assert_eq!(ref_ok.as_deref_ok(), expected_result);
let ref_ok = &Result::Ok::<Vec<i32>, u32>(vec![1, 2, 3, 4, 5]);
- let expected_result = Result::Ok::<&[i32], &u32>(&[1, 2, 3, 4, 5][..]);
+ let expected_result = Result::Ok::<&[i32], &u32>([1, 2, 3, 4, 5].as_slice());
assert_eq!(ref_ok.as_deref_ok(), expected_result);
// &Result<T: Deref, E: Deref>::Ok(T).as_deref() ->
@@ -251,7 +253,7 @@ fn test_result_as_deref() {
assert_eq!(ref_ok.as_deref(), expected_result);
let ref_ok = &Result::Ok::<Vec<i32>, &u32>(vec![1, 2, 3, 4, 5]);
- let expected_result = Result::Ok::<&[i32], &u32>(&[1, 2, 3, 4, 5][..]);
+ let expected_result = Result::Ok::<&[i32], &u32>([1, 2, 3, 4, 5].as_slice());
assert_eq!(ref_ok.as_deref(), expected_result);
// &Result<T, E: Deref>::Err(T).as_deref_err() ->
@@ -265,7 +267,7 @@ fn test_result_as_deref() {
assert_eq!(ref_err.as_deref_err(), expected_result);
let ref_err = &Result::Err::<u32, Vec<i32>>(vec![5, 4, 3, 2, 1]);
- let expected_result = Result::Err::<&u32, &[i32]>(&[5, 4, 3, 2, 1][..]);
+ let expected_result = Result::Err::<&u32, &[i32]>([5, 4, 3, 2, 1].as_slice());
assert_eq!(ref_err.as_deref_err(), expected_result);
// &Result<T: Deref, E: Deref>::Err(T).as_deref_err() ->
@@ -279,7 +281,7 @@ fn test_result_as_deref() {
assert_eq!(ref_err.as_deref(), expected_result);
let ref_err = &Result::Err::<&u32, Vec<i32>>(vec![5, 4, 3, 2, 1]);
- let expected_result = Result::Err::<&u32, &[i32]>(&[5, 4, 3, 2, 1][..]);
+ let expected_result = Result::Err::<&u32, &[i32]>([5, 4, 3, 2, 1].as_slice());
assert_eq!(ref_err.as_deref(), expected_result);
// The following cases test calling `as_deref_*` with the wrong variant (i.e.
@@ -316,3 +318,122 @@ fn test_result_as_deref() {
let expected_result = Result::Err::<&u32, &[i32; 5]>(&[5, 4, 3, 2, 1]);
assert_eq!(ref_err.as_deref_ok(), expected_result);
}
+
+#[test]
+fn test_result_as_deref_mut() {
+ // &mut Result<T: Deref, E>::Ok(T).as_deref_mut_ok() ->
+ // Result<&mut T::Deref::Target, &mut E>::Ok(&mut *T)
+ let mut val = 42;
+ let mut expected_val = 42;
+ let mut_ok = &mut Result::Ok::<&mut i32, u8>(&mut val);
+ let expected_result = Result::Ok::<&mut i32, &mut u8>(&mut expected_val);
+ assert_eq!(mut_ok.as_deref_mut_ok(), expected_result);
+
+ let mut expected_string = String::from("a result");
+ let mut_ok = &mut Result::Ok::<String, u32>(expected_string.clone());
+ let expected_result = Result::Ok::<&mut str, &mut u32>(expected_string.deref_mut());
+ assert_eq!(mut_ok.as_deref_mut_ok(), expected_result);
+
+ let mut expected_vec = vec![1, 2, 3, 4, 5];
+ let mut_ok = &mut Result::Ok::<Vec<i32>, u32>(expected_vec.clone());
+ let expected_result = Result::Ok::<&mut [i32], &mut u32>(expected_vec.as_mut_slice());
+ assert_eq!(mut_ok.as_deref_mut_ok(), expected_result);
+
+ // &mut Result<T: Deref, E: Deref>::Ok(T).as_deref_mut() ->
+ // Result<&mut T::Deref::Target, &mut E::Deref::Target>::Ok(&mut *T)
+ let mut val = 42;
+ let mut expected_val = 42;
+ let mut_ok = &mut Result::Ok::<&mut i32, &mut u8>(&mut val);
+ let expected_result = Result::Ok::<&mut i32, &mut u8>(&mut expected_val);
+ assert_eq!(mut_ok.as_deref_mut(), expected_result);
+
+ let mut expected_string = String::from("a result");
+ let mut_ok = &mut Result::Ok::<String, &mut u32>(expected_string.clone());
+ let expected_result = Result::Ok::<&mut str, &mut u32>(expected_string.deref_mut());
+ assert_eq!(mut_ok.as_deref_mut(), expected_result);
+
+ let mut expected_vec = vec![1, 2, 3, 4, 5];
+ let mut_ok = &mut Result::Ok::<Vec<i32>, &mut u32>(expected_vec.clone());
+ let expected_result = Result::Ok::<&mut [i32], &mut u32>(expected_vec.as_mut_slice());
+ assert_eq!(mut_ok.as_deref_mut(), expected_result);
+
+ // &mut Result<T, E: Deref>::Err(T).as_deref_mut_err() ->
+ // Result<&mut T, &mut E::Deref::Target>::Err(&mut *E)
+ let mut val = 41;
+ let mut expected_val = 41;
+ let mut_err = &mut Result::Err::<u8, &mut i32>(&mut val);
+ let expected_result = Result::Err::<&mut u8, &mut i32>(&mut expected_val);
+ assert_eq!(mut_err.as_deref_mut_err(), expected_result);
+
+ let mut expected_string = String::from("an error");
+ let mut_err = &mut Result::Err::<u32, String>(expected_string.clone());
+ let expected_result = Result::Err::<&mut u32, &mut str>(expected_string.deref_mut());
+ assert_eq!(mut_err.as_deref_mut_err(), expected_result);
+
+ let mut expected_vec = vec![5, 4, 3, 2, 1];
+ let mut_err = &mut Result::Err::<u32, Vec<i32>>(expected_vec.clone());
+ let expected_result = Result::Err::<&mut u32, &mut [i32]>(expected_vec.as_mut_slice());
+ assert_eq!(mut_err.as_deref_mut_err(), expected_result);
+
+ // &mut Result<T: Deref, E: Deref>::Err(T).as_deref_mut_err() ->
+ // Result<&mut T, &mut E::Deref::Target>::Err(&mut *E)
+ let mut val = 41;
+ let mut expected_val = 41;
+ let mut_err = &mut Result::Err::<&mut u8, &mut i32>(&mut val);
+ let expected_result = Result::Err::<&mut u8, &mut i32>(&mut expected_val);
+ assert_eq!(mut_err.as_deref_mut(), expected_result);
+
+ let mut expected_string = String::from("an error");
+ let mut_err = &mut Result::Err::<&mut u32, String>(expected_string.clone());
+ let expected_result = Result::Err::<&mut u32, &mut str>(expected_string.as_mut_str());
+ assert_eq!(mut_err.as_deref_mut(), expected_result);
+
+ let mut expected_vec = vec![5, 4, 3, 2, 1];
+ let mut_err = &mut Result::Err::<&mut u32, Vec<i32>>(expected_vec.clone());
+ let expected_result = Result::Err::<&mut u32, &mut [i32]>(expected_vec.as_mut_slice());
+ assert_eq!(mut_err.as_deref_mut(), expected_result);
+
+ // The following cases test calling `as_deref_mut_*` with the wrong variant (i.e.
+ // `as_deref_mut_ok()` with a `Result::Err()`, or `as_deref_mut_err()` with a `Result::Ok()`.
+ // While uncommon, these cases are supported to ensure that an `as_deref_mut_*`
+ // call can still be made even when one of the Result types does not implement
+ // `Deref` (for example, std::io::Error).
+
+ // &mut Result<T, E: Deref>::Ok(T).as_deref_mut_err() ->
+ // Result<&mut T, &mut E::Deref::Target>::Ok(&mut T)
+ let mut expected_val = 42;
+ let mut_ok = &mut Result::Ok::<i32, &mut u8>(expected_val.clone());
+ let expected_result = Result::Ok::<&mut i32, &mut u8>(&mut expected_val);
+ assert_eq!(mut_ok.as_deref_mut_err(), expected_result);
+
+ let string = String::from("a result");
+ let expected_string = string.clone();
+ let mut ref_str = expected_string.as_ref();
+ let mut_ok = &mut Result::Ok::<&str, &mut u32>(string.as_str());
+ let expected_result = Result::Ok::<&mut &str, &mut u32>(&mut ref_str);
+ assert_eq!(mut_ok.as_deref_mut_err(), expected_result);
+
+ let mut expected_arr = [1, 2, 3, 4, 5];
+ let mut_ok = &mut Result::Ok::<[i32; 5], &mut u32>(expected_arr.clone());
+ let expected_result = Result::Ok::<&mut [i32; 5], &mut u32>(&mut expected_arr);
+ assert_eq!(mut_ok.as_deref_mut_err(), expected_result);
+
+ // &mut Result<T: Deref, E>::Err(E).as_deref_mut_ok() ->
+ // Result<&mut T::Deref::Target, &mut E>::Err(&mut E)
+ let mut expected_val = 41;
+ let mut_err = &mut Result::Err::<&mut u8, i32>(expected_val.clone());
+ let expected_result = Result::Err::<&mut u8, &mut i32>(&mut expected_val);
+ assert_eq!(mut_err.as_deref_mut_ok(), expected_result);
+
+ let string = String::from("an error");
+ let expected_string = string.clone();
+ let mut ref_str = expected_string.as_ref();
+ let mut_err = &mut Result::Err::<&mut u32, &str>(string.as_str());
+ let expected_result = Result::Err::<&mut u32, &mut &str>(&mut ref_str);
+ assert_eq!(mut_err.as_deref_mut_ok(), expected_result);
+
+ let mut expected_arr = [5, 4, 3, 2, 1];
+ let mut_err = &mut Result::Err::<&mut u32, [i32; 5]>(expected_arr.clone());
+ let expected_result = Result::Err::<&mut u32, &mut [i32; 5]>(&mut expected_arr);
+ assert_eq!(mut_err.as_deref_mut_ok(), expected_result);
+}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref.stderr
index ecf6da87c7901..54efcfd045ae9 100644
--- a/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref.stderr
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref.stderr
@@ -2,7 +2,7 @@ error[E0599]: no method named `as_deref` found for type `std::option::Option<{in
--> $DIR/option-as_deref.rs:4:29
|
LL | let _result = &Some(42).as_deref();
- | ^^^^^^^^
+ | ^^^^^^^^ help: did you mean: `as_ref`
|
= note: the method `as_deref` exists but the following trait bounds were not satisfied:
`{integer} : std::ops::Deref`
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref_mut.rs b/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref_mut.rs
new file mode 100644
index 0000000000000..56aead8d0e00d
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref_mut.rs
@@ -0,0 +1,6 @@
+#![feature(inner_deref)]
+
+fn main() {
+ let _result = &mut Some(42).as_deref_mut();
+//~^ ERROR no method named `as_deref_mut` found for type `std::option::Option<{integer}>`
+}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref_mut.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref_mut.stderr
new file mode 100644
index 0000000000000..2c3a18be67c8f
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/option-as_deref_mut.stderr
@@ -0,0 +1,12 @@
+error[E0599]: no method named `as_deref_mut` found for type `std::option::Option<{integer}>` in the current scope
+ --> $DIR/option-as_deref_mut.rs:4:33
+ |
+LL | let _result = &mut Some(42).as_deref_mut();
+ | ^^^^^^^^^^^^
+ |
+ = note: the method `as_deref_mut` exists but the following trait bounds were not satisfied:
+ `{integer} : std::ops::DerefMut`
+
+error: aborting due to previous error
+
+For more information about this error, try `rustc --explain E0599`.
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref.stderr
index 2e81d323974a7..6007f29e566e5 100644
--- a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref.stderr
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref.stderr
@@ -2,7 +2,7 @@ error[E0599]: no method named `as_deref` found for type `std::result::Result<{in
--> $DIR/result-as_deref.rs:4:27
|
LL | let _result = &Ok(42).as_deref();
- | ^^^^^^^^
+ | ^^^^^^^^ help: did you mean: `as_ref`
|
= note: the method `as_deref` exists but the following trait bounds were not satisfied:
`{integer} : std::ops::Deref`
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_err.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_err.stderr
index 906b9981ddd7b..2e918b6835b5a 100644
--- a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_err.stderr
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_err.stderr
@@ -2,7 +2,7 @@ error[E0599]: no method named `as_deref_err` found for type `std::result::Result
--> $DIR/result-as_deref_err.rs:4:28
|
LL | let _result = &Err(41).as_deref_err();
- | ^^^^^^^^^^^^
+ | ^^^^^^^^^^^^ help: did you mean: `as_deref_ok`
|
= note: the method `as_deref_err` exists but the following trait bounds were not satisfied:
`{integer} : std::ops::Deref`
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut.rs b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut.rs
new file mode 100644
index 0000000000000..c897ab3531f0e
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut.rs
@@ -0,0 +1,6 @@
+#![feature(inner_deref)]
+
+fn main() {
+ let _result = &mut Ok(42).as_deref_mut();
+//~^ ERROR no method named `as_deref_mut` found
+}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut.stderr
new file mode 100644
index 0000000000000..3d10cad201ec4
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut.stderr
@@ -0,0 +1,12 @@
+error[E0599]: no method named `as_deref_mut` found for type `std::result::Result<{integer}, _>` in the current scope
+ --> $DIR/result-as_deref_mut.rs:4:31
+ |
+LL | let _result = &mut Ok(42).as_deref_mut();
+ | ^^^^^^^^^^^^ help: did you mean: `as_deref_err`
+ |
+ = note: the method `as_deref_mut` exists but the following trait bounds were not satisfied:
+ `{integer} : std::ops::DerefMut`
+
+error: aborting due to previous error
+
+For more information about this error, try `rustc --explain E0599`.
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_err.rs b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_err.rs
new file mode 100644
index 0000000000000..b7849ecb6d242
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_err.rs
@@ -0,0 +1,6 @@
+#![feature(inner_deref)]
+
+fn main() {
+ let _result = &mut Err(41).as_deref_mut_err();
+//~^ ERROR no method named `as_deref_mut_err` found
+}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_err.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_err.stderr
new file mode 100644
index 0000000000000..99f941d1bedad
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_err.stderr
@@ -0,0 +1,12 @@
+error[E0599]: no method named `as_deref_mut_err` found for type `std::result::Result<_, {integer}>` in the current scope
+ --> $DIR/result-as_deref_mut_err.rs:4:32
+ |
+LL | let _result = &mut Err(41).as_deref_mut_err();
+ | ^^^^^^^^^^^^^^^^ help: did you mean: `as_deref_mut_ok`
+ |
+ = note: the method `as_deref_mut_err` exists but the following trait bounds were not satisfied:
+ `{integer} : std::ops::DerefMut`
+
+error: aborting due to previous error
+
+For more information about this error, try `rustc --explain E0599`.
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_ok.rs b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_ok.rs
new file mode 100644
index 0000000000000..54b695a0865f1
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_ok.rs
@@ -0,0 +1,6 @@
+#![feature(inner_deref)]
+
+fn main() {
+ let _result = &mut Ok(42).as_deref_mut_ok();
+//~^ ERROR no method named `as_deref_mut_ok` found
+}
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_ok.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_ok.stderr
new file mode 100644
index 0000000000000..6d2b019541ad0
--- /dev/null
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_mut_ok.stderr
@@ -0,0 +1,12 @@
+error[E0599]: no method named `as_deref_mut_ok` found for type `std::result::Result<{integer}, _>` in the current scope
+ --> $DIR/result-as_deref_mut_ok.rs:4:31
+ |
+LL | let _result = &mut Ok(42).as_deref_mut_ok();
+ | ^^^^^^^^^^^^^^^ help: did you mean: `as_deref_mut_err`
+ |
+ = note: the method `as_deref_mut_ok` exists but the following trait bounds were not satisfied:
+ `{integer} : std::ops::DerefMut`
+
+error: aborting due to previous error
+
+For more information about this error, try `rustc --explain E0599`.
diff --git a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_ok.stderr b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_ok.stderr
index 2417efde40d3c..5800bd37f9f7f 100644
--- a/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_ok.stderr
+++ b/src/test/ui/issues/issue-50264-inner-deref-trait/result-as_deref_ok.stderr
@@ -2,7 +2,7 @@ error[E0599]: no method named `as_deref_ok` found for type `std::result::Result<
--> $DIR/result-as_deref_ok.rs:4:27
|
LL | let _result = &Ok(42).as_deref_ok();
- | ^^^^^^^^^^^
+ | ^^^^^^^^^^^ help: did you mean: `as_deref_err`
|
= note: the method `as_deref_ok` exists but the following trait bounds were not satisfied:
`{integer} : std::ops::Deref`
From c31b60d9e19d8e8de7d1b42daff2655068ebf481 Mon Sep 17 00:00:00 2001
From: Brad Gibson <b2b@humanenginuity.com>
Date: Mon, 1 Apr 2019 20:08:27 -0700
Subject: [PATCH 3/3] fixed breaking changes
---
src/librustdoc/html/render.rs | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/librustdoc/html/render.rs b/src/librustdoc/html/render.rs
index 3ee131d8f5c8c..21d13864f6b22 100644
--- a/src/librustdoc/html/render.rs
+++ b/src/librustdoc/html/render.rs
@@ -1158,7 +1158,7 @@ themePicker.onblur = handleThemeButtonsBlur;
title: "Index of crates",
css_class: "mod",
root_path: "./",
- static_root_path: cx.shared.static_root_path.deref(),
+ static_root_path: cx.shared.static_root_path.as_deref(),
description: "List of crates",
keywords: BASIC_KEYWORDS,
resource_suffix: &cx.shared.resource_suffix,
@@ -1490,7 +1490,7 @@ impl<'a> SourceCollector<'a> {
title: &title,
css_class: "source",
root_path: &root_path,
- static_root_path: self.scx.static_root_path.deref(),
+ static_root_path: self.scx.static_root_path.as_deref(),
description: &desc,
keywords: BASIC_KEYWORDS,
resource_suffix: &self.scx.resource_suffix,
@@ -2088,7 +2088,7 @@ impl Context {
title: "List of all items in this crate",
css_class: "mod",
root_path: "../",
- static_root_path: self.shared.static_root_path.deref(),
+ static_root_path: self.shared.static_root_path.as_deref(),
description: "List of all items in this crate",
keywords: BASIC_KEYWORDS,
resource_suffix: &self.shared.resource_suffix,
@@ -2169,7 +2169,7 @@ impl Context {
let page = layout::Page {
css_class: tyname,
root_path: &self.root_path(),
- static_root_path: self.shared.static_root_path.deref(),
+ static_root_path: self.shared.static_root_path.as_deref(),
title: &title,
description: &desc,
keywords: &keywords,