-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Verify llvm-needs-components are not empty and match the --target value #144042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dpaoliello
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
dpaoliello:verifyllvmcomp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+263
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot has assigned @albertlarsan68. Use |
r? jieyouxu |
67d476a
to
15dc6a8
Compare
This comment has been minimized.
This comment has been minimized.
15dc6a8
to
a852fa6
Compare
This comment has been minimized.
This comment has been minimized.
a852fa6
to
b3d78ec
Compare
This comment has been minimized.
This comment has been minimized.
b3d78ec
to
6a8c18b
Compare
☔ The latest upstream changes (presumably #144181) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
A-tidy
Area: The tidy tool
PG-exploit-mitigations
Project group: Exploit mitigations
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently discovered a test with an empty
llvm-needs-components
entry (fixed in rust-lang/rust#149178) which meant that it didn't work correctly when building Rust with a limited set of LLVM targets.This change makes a pair of improvements to prevent this issue from creeping in again:
compiletest
will now raise an error if there is an empty value.target_specific_tests
tidy checker to map targets to LLVM components, to verify that any existingllvm-needs-components
contains the target being used.I also fixed all the issues flagged by the improved tidy checker.