-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-ioArea: `std::io`, `std::fs`, `std::net` and `std::path`Area: `std::io`, `std::fs`, `std::net` and `std::path`C-bugCategory: This is a bug.Category: This is a bug.O-windowsOperating system: WindowsOperating system: WindowsP-highHigh priorityHigh priorityT-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Description
d154185 updated lots of code in library/std/src/sys/windows/ to use the new APIs, but did not modify usages in the conitional UWP implementations like:
rust/library/std/src/sys/windows/fs.rs
Line 360 in 47ae8de
self.handle.raw(), - https://github.com/rust-lang/rust/blob/master/library/std/src/sys/windows/fs.rs#L388
rust/library/std/src/sys/windows/stdio_uwp.rs
Lines 28 to 29 in 47ae8de
let handle = Handle::new(handle); ManuallyDrop::new(handle).write(data) rust/library/std/src/sys/windows/stdio_uwp.rs
Lines 41 to 42 in 47ae8de
let handle = Handle::new(handle); ManuallyDrop::new(handle).read(buf)
This manifests as a bunch of compile errors when building with --target x86_64-uwp-windows-msvc
and -Z build-std
.
Metadata
Metadata
Assignees
Labels
A-ioArea: `std::io`, `std::fs`, `std::net` and `std::path`Area: `std::io`, `std::fs`, `std::net` and `std::path`C-bugCategory: This is a bug.Category: This is a bug.O-windowsOperating system: WindowsOperating system: WindowsP-highHigh priorityHigh priorityT-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.