Open
Description
#83185 deleted types_escaping_snapshot in compiler/rustc_infer/src/infer/type_variable.rs, but there are several comments remaining referencing that function, some of which seem to indicate no longer necessary operations. This code, to my knowledge, is pretty finicky, so we will want to be careful, but there may be some performance (or at least cleanup) wins left there.
cc @jyn514
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
jyn514 commentedon Apr 26, 2021
I'm not sure what's going on with that code. The comment on
impl sv::SnapshotVecDelegate for Delegate {
saysbut when I try to remove the impl I get lots of errors:
including from functions that are still used, like
values()
.The comment was added in 57a593f - @nikomatsakis do any obvious cleanups come to mind now that types_escaping_snapshot no longer exists?
jyn514 commentedon Apr 26, 2021
I did remove
rust/compiler/rustc_infer/src/infer/type_variable.rs
Line 227 in 6bed7e1
self.undo_log
can be removed altogether?nikomatsakis commentedon Apr 27, 2021
Hmm
nikomatsakis commentedon Apr 27, 2021
I don't think you can remove the
undo_log
, that's needed for probes and other things, but I might be forgetting something. There might be some simplifications possible.