Skip to content

missing_fragment_specifier hard error #76605

Closed
@pietroalbini

Description

@pietroalbini
Member

In the beta run for Rust 1.47 the release team discovered that #75516 is breaking more than 475 crates or git repositories currently compiling, across at least the following crates:

  • js-sys
  • clap
  • time-macros-impl

cc @petrochenkov @matklad @rust-lang/release

Activity

added
A-parserArea: The lexing & parsing of Rust source code to an AST
C-bugCategory: This is a bug.
on Sep 11, 2020
added
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
on Sep 11, 2020
added
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Sep 11, 2020
pietroalbini

pietroalbini commented on Sep 11, 2020

@pietroalbini
MemberAuthor

Personally I think that's too much breakage to land, even though it was a deprecation warning since 2017.

removed
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
on Sep 11, 2020
petrochenkov

petrochenkov commented on Sep 11, 2020

@petrochenkov
Contributor

I agree that it's not an acceptable breakage, although I suspect that most of it happens due to committed Cargo.locks.
I think we can add a hack accepting a missing fragment specifier for the 2-3 specific crates responsible for majority of the breakage, like it was done in #73345.
(In a more local way than before #75516, without Option<NonterminalKind> in MetaVarDecl, and without missing_fragment_specifiers in session.)

Mark-Simulacrum

Mark-Simulacrum commented on Sep 11, 2020

@Mark-Simulacrum
Member

We could also make it a hard warning rather than error for all crates, but I'm not sure if that's better. It also doesn't need session state.

tmandry

tmandry commented on Sep 12, 2020

@tmandry
Member

To expand a bit: cargo hides warnings generated by your dependencies, so crate owners don't feel the pain of depending on these old versions. I believe it passes -Awarnings to rustc, but otherwise passes through the output unchanged. If we had a warning that printed in spite of -Awarnings it would encourage people to update their deps.

I assume that is what is meant by "hard warning"?

added
T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.
on Oct 2, 2020
Mark-Simulacrum

Mark-Simulacrum commented on Oct 2, 2020

@Mark-Simulacrum
Member

I've posted a revert to current beta (#77456) but we still need to fix this on master. Moving milestone to 1.48, though.

added this to the 1.48.0 milestone on Oct 2, 2020

26 remaining items

added 4 commits that reference this issue on Dec 22, 2020

Rollup merge of rust-lang#80296 - wesleywiser:revert_missing_fragment…

32c30b1

Rollup merge of rust-lang#80296 - wesleywiser:revert_missing_fragment…

2f3f5f0

Rollup merge of rust-lang#80296 - wesleywiser:revert_missing_fragment…

ba5a021

Rollup merge of rust-lang#80296 - wesleywiser:revert_missing_fragment…

58b28e2
added a commit that references this issue on Dec 25, 2020

Auto merge of rust-lang#80296 - wesleywiser:revert_missing_fragment_s…

1832bdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

A-parserArea: The lexing & parsing of Rust source code to an ASTC-bugCategory: This is a bug.P-criticalCritical priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

Type

No type

Projects

No projects

Relationships

None yet

    Development

    Participants

    @wesleywiser@Aaron1011@estebank@tmandry@pietroalbini

    Issue actions

      missing_fragment_specifier hard error · Issue #76605 · rust-lang/rust