Skip to content

x.py clippy no longer works #142156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthiaskrgr opened this issue Jun 7, 2025 · 1 comment
Closed

x.py clippy no longer works #142156

matthiaskrgr opened this issue Jun 7, 2025 · 1 comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Jun 7, 2025

Summary

Command used

./x.py clippy

Expected behaviour

clippy is run on the compiler.
this used to download a beta clippy and run it on the compiler

Actual behaviour

This may no longer work as the required cfg(bootstrap) has been removed

Linting stage0 library {alloc, core, panic_abort, panic_unwind, proc_macro, std, sysroot, test, unwind} (x86_64-unknown-linux-gnu)
    Checking core v0.0.0 (/home/matthias/vcs/github/rust/library/core)
error: cannot find a built-in macro with name `autodiff_forward`
    --> library/core/src/macros/mod.rs:1536:5
     |
1536 | /     pub macro autodiff_forward($item:item) {
1537 | |         /* compiler built-in */
1538 | |     }
     | |_____^

error: cannot find a built-in macro with name `autodiff_reverse`
    --> library/core/src/macros/mod.rs:1554:5
     |
1554 | /     pub macro autodiff_reverse($item:item) {
1555 | |         /* compiler built-in */
1556 | |     }
     | |_____^
..
..
..
..


Bootstrap configuration (bootstrap.toml)

change-id = 123711
[llvm]
download-ci-llvm = true
ninja = true
[build]
check-stage = 0
doc-stage = 0
build-stage = 1
test-stage = 1
dist-stage = 2
install-stage = 2
bench-stage = 2
extended = true
tools = [
    "cargo",
    "clippy",
    "rustdoc",
    "rustfmt",
    "rust-analyzer",
    "rust-analyzer-proc-macro-srv",
    "analysis",
    "src",
    "miri", "cargo-miri" # for dev/nightly channels
]
sanitizers = false
profiler = false
low-priority = true
[install]
[rust]
debug = true
download-rustc = false
codegen-units = 0
codegen-units-std = 0
debug-assertions=true
debuginfo-level = 2
lto = "off"
backtrace-on-ice = true
[target.x86_64-unknown-linux-gnu]
ar = "llvm-ar"
ranlib = "llvm-ranlib"
[dist]

Operating system

Linux

HEAD

c57119b

Additional context

x.py clippy --stage=1
still works but would require re-bootstrapping compiler + clippy if we do a change to compiler source code

cc #141901

@matthiaskrgr matthiaskrgr added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Jun 7, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 7, 2025
@Noratrieb Noratrieb removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 7, 2025
@jieyouxu jieyouxu added the A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust label Jun 8, 2025
@onur-ozkan
Copy link
Member

You are explicitly setting check stage to 0 in your build configuration, which causes x clippy to check the library sources with the stage 0 compiler. This is not possible as the library tree requires stage 1 compiler.

Closing this as this isn't a bug but rather your configuration is invalid to the command you are invoking. Either remove check-stage = 0 from your configuration or avoid running clippy on the library tree (e.g., use x clippy --skip library).

@onur-ozkan onur-ozkan closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

5 participants