Skip to content

Tracking Issue for nvptx_target_feature #141468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
jedbrown opened this issue May 23, 2025 · 0 comments
Open
2 tasks

Tracking Issue for nvptx_target_feature #141468

jedbrown opened this issue May 23, 2025 · 0 comments
Labels
A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC O-NVPTX Target: the NVPTX LLVM backend for running rust on GPUs, https://llvm.org/docs/NVPTXUsage.html T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jedbrown
Copy link
Contributor

This is a tracking issue for the NVPTX part of #44839 (RFC 2045; rust-lang/rfcs#2045).
The feature gate for the issue is #![feature(nvptx_target_feature)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Discussion comments will get marked as off-topic or deleted.
Repeated discussions on the tracking issue may lead to the tracking issue getting locked.

Steps

Unresolved Questions

  • Should ptx* and sm_* be target features or should they be target modifiers; cf. https://internals.rust-lang.org/t/why-are-forbidden-target-features-disallowed-in-cfg-target-feature/22944/4.
    • They are exposed as LLVM features, but LLVM does not currently intend these features to be applied as function attributes. As such, we'd prefer that it be erroneous to use #[target_feature(enable = "ptx80")].
    • This relates to how core::arch::nvptx is compiled. If we use #[cfg(target_feature = "ptx80")] for relevant intrinsics, then the user must build their crates using -Zbuild-std=core with appropriate RUSTFLAGS.
  • When target features are activated using -Ctarget-feature=+ptx80 or #[target_feature(enable = "ptx80")], all the implied features are also added to LLVM functions. LLVM doesn't officially support that (though it seems to work with LLVM-20), so it would be preferable to only pass the highest level LLVM feature and ensure that is applied at crate/PTX module granularity.

Implementation history

@rustbot label +O-NVPTX +A-target-feature

@jedbrown jedbrown added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label May 23, 2025
@rustbot rustbot added A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. O-NVPTX Target: the NVPTX LLVM backend for running rust on GPUs, https://llvm.org/docs/NVPTXUsage.html labels May 23, 2025
@jieyouxu jieyouxu added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC O-NVPTX Target: the NVPTX LLVM backend for running rust on GPUs, https://llvm.org/docs/NVPTXUsage.html T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants