Skip to content

inline_asm missing normalization #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lcnr opened this issue Apr 25, 2025 · 0 comments · May be fixed by rust-lang/rust#140302
Open

inline_asm missing normalization #189

lcnr opened this issue Apr 25, 2025 · 0 comments · May be fixed by rust-lang/rust#140302
Assignees
@compiler-errors
Labels
from-crater A regression found via a crater run, not part of our test suite

Comments

@lcnr
Copy link
Contributor

lcnr commented Apr 25, 2025 •
edited
Loading

https://crater-reports.s3.amazonaws.com/pr-133502-4/try%230c7fed2b7584d310ca8221267fa1b3bec4df427f/reg/solana-account-decoder-2.1.21/log.txt

fn invoke(pc_section: &[usize]) {
    unsafe {
        std::arch::asm!(
            "/* {} */",
            in(reg) pc_section[0]
        );
    }
}

results in

error: cannot use value of type `<[usize] as Index<usize>>::Output` for inline assembly
 --> src/main.rs:5:21
  |
5 |             in(reg) pc_section[0]
  |                     ^^^^^^^^^^^^^
  |
  = note: only integers, floats, SIMD vectors, pointers and function pointers can be used as arguments for inline assembly
@lcnr lcnr added the from-crater A regression found via a crater run, not part of our test suite label Apr 25, 2025
@compiler-errors compiler-errors linked a pull request Apr 25, 2025 that will close this issue
Open
@compiler-errors compiler-errors self-assigned this Apr 25, 2025
@lcnr lcnr moved this from unknown to in progress in -Znext-solver=globally Apr 25, 2025
jhpratt added a commit to jhpratt/rust that referenced this issue Apr 26, 2025
@jhpratt
Rollup merge of rust-lang#140302 - compiler-errors:inline_asm-bug, r=…
76f9fa6 
…lcnr

Move inline asm check to typeck, properly handle aliases

Pull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. To fix rust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`.

r? lcnr
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Apr 26, 2025
@matthiaskrgr
Rollup merge of rust-lang#140302 - compiler-errors:inline_asm-bug, r=…
ce40f86 
…lcnr

Move inline asm check to typeck, properly handle aliases

Pull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. To fix rust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`.

r? lcnr
ChrisDenton added a commit to ChrisDenton/rust that referenced this issue Apr 28, 2025
@ChrisDenton
Rollup merge of rust-lang#140302 - compiler-errors:inline_asm-bug, r=…
e81060b 
…lcnr

Move inline asm check to typeck, properly handle aliases

Pull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. To fix rust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`.

r? lcnr
ChrisDenton added a commit to ChrisDenton/rust that referenced this issue Apr 28, 2025
@ChrisDenton
Rollup merge of rust-lang#140302 - compiler-errors:inline_asm-bug, r=…
657bfe0 
…lcnr

Move inline asm check to typeck, properly handle aliases

Pull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. To fix rust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`.

r? lcnr
ChrisDenton added a commit to ChrisDenton/rust that referenced this issue Apr 28, 2025
@ChrisDenton
Rollup merge of rust-lang#140302 - compiler-errors:inline_asm-bug, r=…
3f5406f 
…lcnr

Move inline asm check to typeck, properly handle aliases

Pull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. To fix rust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`.

r? lcnr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compiler-errors compiler-errors

Labels
from-crater A regression found via a crater run, not part of our test suite
Projects
-Znext-solver=globally
Status: in progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move inline asm check to typeck, properly handle aliases compiler-errors/rust
2 participants
@compiler-errors @lcnr