Reject function items as const arguments #136408
Closed
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an ICE caused by using function items as const arguments in generic contexts. Previously, the compiler would panic when encountering such cases due to unsupported behavior in `min_generic_const_args`. This fix improves error handling by detecting function items in `lower_const_arg` and emitting a user-friendly error message instead of crashing. Changes: - Added logic in `hir_ty_lowering::lower_const_arg` to detect and reject function items as const arguments. - Introduced a new UI test (`fn-item-as-const-arg.rs`) to validate the fix. Signed-off-by: Charalampos Mitrodimas <[email protected]>
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
|
HIR ty lowering was modified cc @fmease |
|
Closing, this needs much more thought, as per the comment in compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an ICE caused by using function items as const arguments in generic contexts. Previously, the compiler would panic when encountering such cases due to unsupported behavior in
min_generic_const_args. This fix improves error handling by detecting function items inlower_const_argand emitting a user-friendly error message instead of crashing.Changes:
hir_ty_lowering::lower_const_argto detect and reject function items as const arguments.fn-item-as-const-arg.rs) to validate the fix.Fixes #136337