Skip to content

Tracking Issue for de-stabilizing (and eventually removing?) the old serialization infrastructure (feature gate: rustc_encodable_decodable) #134301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RalfJung opened this issue Dec 14, 2024 · 1 comment
Closed

Tracking Issue for de-stabilizing (and eventually removing?) the old serialization infrastructure (feature gate: rustc_encodable_decodable) #134301

RalfJung opened this issue Dec 14, 2024 · 1 comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Dec 14, 2024 •
edited
Loading

This tracks the progress on rust-lang/libs-team#272. That issue says that #105572 will cause rustc-serialize to stop building; it seems like a semver-compatible update was released to avoid that, so currently that crate can still be used on stable. Since Rust 1.79, the future compatibility report shows this as a warning (even for dependencies).

Implementation:
@RalfJung RalfJung added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Dec 14, 2024
@RalfJung RalfJung mentioned this issue Dec 14, 2024
Closed
@RalfJung RalfJung changed the title Tracking Issue for de-stabilizing (and eventually removing?) the old serialization infrastructure Tracking Issue for de-stabilizing (and eventually removing?) the old serialization infrastructure (feature gate: rustc_encodable_decodable) Dec 14, 2024
@RalfJung RalfJung mentioned this issue Dec 14, 2024
Open
@jieyouxu jieyouxu added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 14, 2024
This was referenced Dec 20, 2024
Open
Closed
Merged
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#134272 - RalfJung:destabilize-rustc_encodab…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
69338c2 
…le_decodable, r=oli-obk

Remove rustc_encodable_decodable feature

This has been shown in future-compat reports since Rust 1.79 (rust-lang#116016), released June 2024. Let's see if crater still finds any issues.

Part of rust-lang#134301.

Cc `@rust-lang/libs-api`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#134272 - RalfJung:destabilize-rustc_encodab…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
48aede0 
…le_decodable, r=oli-obk

Remove rustc_encodable_decodable feature

This has been shown in future-compat reports since Rust 1.79 (rust-lang#116016), released June 2024. Let's see if crater still finds any issues.

Part of rust-lang#134301.

Cc ``@rust-lang/libs-api``
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 2, 2025
@rust-timer
Unrolled build for rust-lang#134272

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
84bd933 
Rollup merge of rust-lang#134272 - RalfJung:destabilize-rustc_encodable_decodable, r=oli-obk

Remove rustc_encodable_decodable feature

This has been shown in future-compat reports since Rust 1.79 (rust-lang#116016), released June 2024. Let's see if crater still finds any issues.

Part of rust-lang#134301.

Cc ``@rust-lang/libs-api``
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this issue Mar 11, 2025
@matthiaskrgr
Rollup merge of rust-lang#134272 - RalfJung:destabilize-rustc_encodab…
57f8c67 
…le_decodable, r=oli-obk

Remove rustc_encodable_decodable feature

This has been shown in future-compat reports since Rust 1.79 (rust-lang#116016), released June 2024. Let's see if crater still finds any issues.

Part of rust-lang#134301.

Cc ``@rust-lang/libs-api``
@RalfJung
Copy link
Member Author

RalfJung commented May 2, 2025

This has been removed in #134272.

@RalfJung RalfJung closed this as completed May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RalfJung @jieyouxu