Skip to content

cdb debuginfo test failures #133107

Closed
Closed
@jieyouxu

Description

@jieyouxu
Member

EDIT: see https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/msvc.20update.20causing.20debuginfo.20failures, runner image update may have updated cdb?

I can't tell if this is a github runner issue, something changed with our x86_64-msvc CI, or a genuine flaky test, but these three tests have been failing on x86_64-msvc:

tests\debuginfo\numeric-types.rs
tests\debuginfo\range-types.rs
tests\debuginfo\unit-type.rs

#133094 (comment)
#133097 (comment)
#133029 (comment)
#132569 (comment)

But

//@ compile-flags:-g
was last modified 3 months ago and I don't recall seeing any PRs recently modifying debuginfo for cdb.

Opening this issue to track the failures.

Activity

added
A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)
A-testsuiteArea: The testsuite used to check the correctness of rustc
C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
C-bugCategory: This is a bug.
on Nov 16, 2024
clubby789

clubby789 commented on Nov 16, 2024

@clubby789
Contributor
changed the title [-]Spurious cdb debuginfo test failures[/-] [+]cdb debuginfo test failures[/+] on Nov 16, 2024
jieyouxu

jieyouxu commented on Nov 16, 2024

@jieyouxu
MemberAuthor

Looks like the output did change following new cdb version in CI

Microsoft (R) Windows Debugger Version 10.0.26100.2161 AMD64
self-assigned this
on Nov 16, 2024
removed their assignment
on Nov 16, 2024
jieyouxu

jieyouxu commented on Nov 16, 2024

@jieyouxu
MemberAuthor

Updating cdb annotations in #133115 but I can't tell if they improved/regressed/whatever, so keeping this issue open even after #133115 merges for the cdb/debuginfo experts to follow-up.

removed
C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
on Nov 16, 2024
added a commit that references this issue on Nov 16, 2024

Auto merge of rust-lang#133115 - jieyouxu:cdb, r=ChrisDenton

jieyouxu

jieyouxu commented on Nov 16, 2024

@jieyouxu
MemberAuthor

Marking numeric-types.rs as 64-bit only for now to unblock the tree (in #133115), follow-up investigations should try to see if that can be made to work with i686-msvc (64-bit isize vs 32-bit isize and thus different underlying int type display).

added a commit that references this issue on Nov 16, 2024

Auto merge of rust-lang#133115 - jieyouxu:cdb, r=chrisdenton

jieyouxu

jieyouxu commented on Dec 23, 2024

@jieyouxu
MemberAuthor

Closing this issue in favor of a more specific issue for the outstanding test coverage regression in #134683.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.O-windows-msvcToolchain: MSVC, Operating system: WindowsT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @clubby789@jieyouxu

        Issue actions

          cdb debuginfo test failures · Issue #133107 · rust-lang/rust