Tracking Issue for mixed_integer_ops_unsigned_sub

[davidzeng0]

Feature gate: #![feature(mixed_integer_ops_unsigned_sub)]

This is a tracking issue for rust-lang/libs-team#386

Public API

impl uX {
    pub const fn checked_sub_signed(self, iX) -> Option<Self>;
    pub const fn overflowing_sub_signed(self, iX) -> (Self, bool);
    pub const fn saturating_sub_signed(self, iX) -> Self;
    pub const fn wrapping_sub_signed(self, iX) -> Self;
}

Steps / History

• ACP: mixed_integer_ops extension libs-team#386
• Implementation: Implement mixed_integer_ops_unsigned_sub #126046
• Final comment period (FCP)¹
• Stabilization PR

Unresolved Questions

• None yet.

Footnotes

1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html ↩

[nxsaken]

Discovered this through the unstable checked_sub_signed. Looks like the impl (#126046) was merged last year. What's needed to stabilize this?

[rustbot]

Error: Only Rust team members can ping teams.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

[callmeclover]

@Amanieu @rust-lang/libs Can we start FCP on this? The ACP (rust-lang/libs-team#386) and implementation (#126046) passed last year.

[Amanieu]

I'm not a huge fan of overflowing_* methods but I think it's fine in this case since it is consistent with the existing ones. The other methods seem fine to me.

@rfcbot merge

[rfcbot]

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @BurntSushi
• @dtolnay
• @joshtriplett
• @m-ou-se

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔