Open
Description
Feature gate: #![feature(mixed_integer_ops_unsigned_sub)]
This is a tracking issue for rust-lang/libs-team#386
Public API
impl uX {
pub const fn checked_sub_signed(self, iX) -> Option<Self>;
pub const fn overflowing_sub_signed(self, iX) -> (Self, bool);
pub const fn saturating_sub_signed(self, iX) -> Self;
pub const fn wrapping_sub_signed(self, iX) -> Self;
}
Steps / History
- Implementation: Implement
mixed_integer_ops_unsigned_sub
#126046Final comment period (FCP)1Stabilization PR
Unresolved Questions
- None yet.
Footnotes
Metadata
Metadata
Assignees
Labels
Category: An issue tracking the progress of sth. like the implementation of an RFCRelevant to the library API team, which will review and decide on the PR/issue.This issue / PR is in PFCP or FCP with a disposition to merge it.The final comment period is finished for this PR / Issue.Announce this issue on triage meeting
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
mixed_integer_ops_unsigned_sub
#126046Rollup merge of rust-lang#126046 - davidzeng0:mixed_integer_ops_unsig…
Unrolled build for rust-lang#126046
nxsaken commentedon May 29, 2025
Discovered this through the unstable
checked_sub_signed
. Looks like the impl (#126046) was merged last year. What's needed to stabilize this?rustbot commentedon Jun 3, 2025
Error: Only Rust team members can ping teams.
Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.
callmeclover commentedon Jun 5, 2025
@Amanieu @rust-lang/libs Can we start FCP on this? The ACP (rust-lang/libs-team#386) and implementation (#126046) passed last year.
Amanieu commentedon Jun 9, 2025
I'm not a huge fan of
overflowing_*
methods but I think it's fine in this case since it is consistent with the existing ones. The other methods seem fine to me.@rfcbot merge
rfcbot commentedon Jun 9, 2025
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
rfcbot commentedon Jun 10, 2025
🔔 This is now entering its final comment period, as per the review above. 🔔
rfcbot commentedon Jun 20, 2025
The final comment period, with a disposition to merge, as per the review above, is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
This will be merged soon.
mixed_integer_ops_unsigned_sub
#142761