Skip to content

internal refactoring: cleanup type relations #121159

Open
@lcnr

Description

@lcnr
Contributor

we should try to clean up our type relations further:

  • try to unify Equate and Sub to make them closer to nll::TypeRelating
    merge Lub and Glb into the same (maybe generic) type relation, prolly just with a field
    reuse more components, e.g. instantiating infer vars should be shared, not only generalize
    completely merge Equate/Sub and nll:TypeRelating

I intend to look into this myself but would also appreciate some help. This is a quite involved and sometimes subtle area however and I don't have the capacity for in-depth mentoring rn

Activity

added
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Feb 15, 2024
changed the title [-]internal refactoring: combine cleanups[/-] [+]internal refactoring: cleanup type relations[/+] on Feb 15, 2024
added
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
E-hardCall for participation: Hard difficulty. Experience needed to fix: A lot.
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.
E-help-wantedCall for participation: Help is requested to fix this issue.
and removed
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Feb 15, 2024
removed
E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.
on Feb 15, 2024
added a commit that references this issue on Feb 19, 2024

Auto merge of rust-lang#121211 - lcnr:nll-relate-handle-infer, r=BoxyUwU

ShoyuVanilla

ShoyuVanilla commented on Mar 10, 2024

@ShoyuVanilla
Member

try to unify Equate and Sub to make them closer to nll::TypeRelating

It seems to be done by #121462, I guess?

ShoyuVanilla

ShoyuVanilla commented on Mar 11, 2024

@ShoyuVanilla
Member

completely merge Equate/Sub and nll:TypeRelating

And nll::TypeRelating is moved into rustc_borrowck in #121321

5 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-technical-debtArea: Internal cleanup workA-type-systemArea: Type systemC-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-typesRelevant to the types team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ShoyuVanilla@fmease@lcnr@jieyouxu@fee1-dead

        Issue actions

          internal refactoring: cleanup type relations · Issue #121159 · rust-lang/rust