-
Notifications
You must be signed in to change notification settings - Fork 65
Rust for Linux project goals: compiler features #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not be enough to make CI pass (the team asks are standardized for the tooling) but at least I know how to fix the issues above.
| Teams | <!-- TEAMS WITH ASKS --> | | ||
| Task owners | <!-- TASK OWNERS --> | | ||
| Status | Proposed, Invited | | ||
| Tracking issue | https://github.com/rust-lang/rust-project-goals/issues/116 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Tracking issue | https://github.com/rust-lang/rust-project-goals/issues/116 | | |
| Teams | <!-- TEAMS WITH ASKS --> | | |
| Task owners | <!-- TASK OWNERS --> | | |
| Status | Proposed | | |
| Tracking issue | [rust-lang/rust-project-goals#116] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit confused by the diff -- should I add those 4 lines even if there are similar rows above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arg GH sucks. Replacing the 4 lines will remove the CI errors for them. The local diff was a replacement of the existing lines, instead of putting everything at the last line :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so it is an artifact of GitHub, got it, thanks! I will do that then. I see the diff says "Proposed", but we don't have concrete "owners" (especially for this one -- the language one there is @dingxiangfei2009 for the two main features). Or what does it mean "Invited"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invited are the ones without owners, so no progress/updates are expected until someone signs up to do that for a given goal. https://rust-lang.github.io/rust-project-goals/about/invited_goals.html. Since you have a list of 3 possible owners of the goal, it didn't look like an Invited one to me but obviously I don't know what your plans are.
It's not super important what this Status says: "Proposed" for a regular goal, or "Proposed for mentorship" for an Invited one. The tooling will accept both, and would not fail to create the subsequent goal RFC for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so the "points of contact" are the "owners"? I thought the "Status" explanation was referring to the "Task owners" instead. I am confused, because in the "Invited" page it says it is the "Task owners", i.e. they people that will do the implementation work, not the "point of contact".
So, in our case, I wrote 3 points of contact, but not owners. For the language goal, @dingxiangfei2009 is the owner of implementing 2 of the main features. For the compiler goal, we don't know yet who would work on what in particular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of contact, formerly known as goal owner, provides the status updates for the goal progress at the very least, but is often going to be involved in driving the work, or doing the work. Task owners are doing the work, and that can include the goal owner.
0136001
to
6c2cfc3
Compare
I guess "Discussion and moral support", "Design meeting" or "Miscellaneous" could be used in the table. |
45183c6
to
43cce4d
Compare
Signed-off-by: Miguel Ojeda <[email protected]>
@rcvalle Thanks! I had seen that one, but I thought it would be an independent one given it focuses on msan/tsan for Tier 1 and |
Compared to the draft we discussed in the call a couple days ago, I mainly added a couple more flags and added the architectures each flag applies to (at least currently).
@rcvalle I think you mentioned we should link the sanitizer goal -- please let me know when you have the link, thanks!
Rendered