Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket connection should timeout and report the timeout when system is overloaded #1093

Open
RalfJung opened this issue Sep 27, 2024 · 4 comments

Comments

@RalfJung
Copy link
Member

To reproduce, open this and click "expand macros". The result after a bit of waiting is this:

Image

I would expect either some sort of error message if the server is overloaded or the invocation timed out, or the macro-expanded output.

@RalfJung
Copy link
Member Author

Of course when I try this again now, the expected output is shown...

But I got the "no output" above at least 3 times. Seems likely that they timed out somewhere in the backend, but that means there's still a bug somewhere where it fails to produce an error message.

@HappiePlant
Copy link

For me the entire site is broken right now, running and building does nothing

@shepmaster
Copy link
Member

It may not seem like it, but this report is music to my ears!

Here's the child container and process graph of the playground around the time you made this report:

Image

Image

I'm pretty sure that prior to #1090, this would have simply killed the entire machine, so this is useful forward progress.

@shepmaster shepmaster changed the title No output and no error when clicking "expand macros" WebSocket connection should timeout and report the timeout when system is overloaded Sep 27, 2024
@RalfJung
Copy link
Member Author

Ah yes, getting no error is certainly better than killing the machine :-)

shepmaster added a commit that referenced this issue Oct 4, 2024
Touches on #1093. We aren't actually timing out, we are just waiting
for a long time. This is a trivial fix, but the bigger fix would be to
indicate that there might be a long wait or offer a deliberate cancel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants