Skip to content

Missing "could be written as" #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Aug 17, 2019 · 1 comment · Fixed by #4436
Closed

Missing "could be written as" #4405

ghost opened this issue Aug 17, 2019 · 1 comment · Fixed by #4436
Labels
A-documentation Area: Adding or improving documentation good first issue These issues are a good way to get started with Clippy

Comments

@ghost
Copy link

ghost commented Aug 17, 2019

There are some lints missing a "could be written as".
If I am on a clippy page, like manual_memcpy, I really like to not just see what is wrong in the example but also see how to fix the example.

Is there an interest in adding some more "could be written as" like in #4404 ?

I would be happy to fill some PRs for this :)
@phansch phansch added good first issue These issues are a good way to get started with Clippy A-documentation Area: Adding or improving documentation labels Aug 18, 2019
@phansch
Copy link
Member

phansch commented Aug 18, 2019

Yes, that would be really nice to have! In fact, it's already part of the 'Adding Lints' docs here, but could probably be highlighted in a sentence below, too.

@ghost ghost mentioned this issue Aug 22, 2019
Merged
bors added a commit that referenced this issue Aug 23, 2019
@bors
Auto merge of #4436 - BO41:written_as, r=phansch
86916ea 
Add some "could be written as" examples

fixes #4405
changelog: none
@bors bors closed this as completed in ba66813 Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-documentation Area: Adding or improving documentation good first issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add some "could be written as" examples
1 participant
@phansch