test to_string_in_format_args_incremental fails in a read-only working directory
#11126
Comments
Noratrieb
changed the title
to_string_in_format_args_incremental fails in a read-only file systemto_string_in_format_args_incremental fails in a read-only working directory
|
We could add some variable-replacement scheme so that we can specify |
|
I am currently getting this issue as well, When i ran I'm not experienced enough to know what the solution is and am currently stuck because of this. An update on the situation would be reassuring, Thank you all. |
|
What was the other, and could you show the errors @utkrsharmaa? Also huh, the test still exists in the clippy repo |
|
@Alexendoo The other one was the Lint I'm currently working on, It's my first time writing a lint so i was struggling getting the tests to pass. I posted a comment regarding under the issue. I really don't know why it's causing problems. Maybe it's the |
If you sync with |
|
Thanks @utkrsharmaa! @blyxyas looks like this is down to the The query could be made |
|
I'd say that it's preferable to instruct contributors to do a Does the query system re-eval queries if the compiler version changes? |
Not exactly, but Dylint leans on Cargo more. Before running lints from a library, Dylint runs |
This one makes me lose a lot of time and CPU resources by forcing me to run |
It starts fresh, the filename hash would change so the same crate would have two entries in
The situation I was thinking of is:
But I haven't looked into how it works exactly, I'm assuming it has incremental enabled and that both runs would have the same rustc hash |
Yes, re incremental and same rustc hash. One normally runs Dylint by adding something like the following the Cargo.toml file: [workspace.metadata.dylint]
libraries = [
{ git = "https://github.com/trailofbits/dylint", pattern = "examples/general" },
]In that sense, there are two ways to interpret "run it again with another lint added". One is to add another lint to a library already in use, e.g., The second is to add another library, e.g.: [workspace.metadata.dylint]
libraries = [
{ git = "https://github.com/trailofbits/dylint", pattern = "examples/general" },
{ git = "https://github.com/trailofbits/dylint", pattern = "examples/restriction/try_io_result" },
]In that case, the lints would be re-run because which lints are run is recorded in |
|
It'd be worth testing to see if that ICEs assuming it's using a relatively recent rust version, it also requires that the added lint is warn by default or It's a separate issue from rerun detection, the ICE happens when the first run's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The test creates a file in the current working directory, which doesn't work in rust-lang/rust CI. It should be changed to create the incremental directory somewhere else, I'm not sure what the best solution would be here.
I deleted the test in rust-lang/rust#113450 so it will be removed in the next sync.
cc @Alexendoo @flip1995 @oli-obk
Version
Additional Labels
No response
The text was updated successfully, but these errors were encountered: