-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Open
Labels
C-tracking-issueCategory: Tracking IssueCategory: Tracking IssueE-mediumCall for participation: Medium difficulty level problem and requires some initial experience.Call for participation: Medium difficulty level problem and requires some initial experience.good first issueThese issues are a good way to get started with ClippyThese issues are a good way to get started with Clippy
Description
Description
#13098 introduced @no-rustfix
annotations, that can be removed by changing the suggestion to a multipart suggestion:
//@no-rustfix: need to change the suggestion to a multipart suggestion
The affected test files are:
ui-toml/max_suggested_slice_pattern_length/index_refutable_slice.rs
ui/crashes/ice-3717.rs
ui/derivable_impls.rs
ui/index_refutable_slice/if_let_slice_binding.rs
ui/index_refutable_slice/slice_indexing_in_macro.rs
ui/let_unit.rs
ui/manual_assert.rs
ui/manual_async_fn.rs
ui/manual_split_once.rs
ui/match_same_arms2.rs
ui/significant_drop_tightening.rs
ui/unnecessary_iter_cloned.rs
ui/unnecessary_to_owned.rs
To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
To fix some of those:
- Pick one test and leave a comment about it
- Remove the
@no-rustfix
annotation - Change the lint suggestion building to use
multipart_suggestion
over the current implementation - write a comment here or mention this issue in the PR so that it gets marked as resolved.
Version
No response
Additional Labels
No response
Metadata
Metadata
Assignees
Labels
C-tracking-issueCategory: Tracking IssueCategory: Tracking IssueE-mediumCall for participation: Medium difficulty level problem and requires some initial experience.Call for participation: Medium difficulty level problem and requires some initial experience.good first issueThese issues are a good way to get started with ClippyThese issues are a good way to get started with Clippy
Activity
@no-rustfix annotation and updated suggestions to multipart_suggestion
as required by #13099 #13216ibilalkayy commentedon Aug 4, 2024
Hey @flip1995, I just sent a PR to solve a problem that you mentioned in this issue. Thank you!
add a test for ice-3717.rs
Auto merge of #13230 - kyoto7250:fix_issue_13099, r=flip1995
Auto merge of #13230 - kyoto7250:fix_issue_13099, r=flip1995
flip1995 commentedon Sep 23, 2024
Copying a comment by
@kyoto7250
, that explains the tasks here a bit better than I have in the issue: #13216 (comment)scottgerring commentedon Nov 22, 2024
I pushed a change to address this for
ui/derivable_impls.rs
- if it looks sane, i'll polish up a few of the others too!scottgerring commentedon Nov 25, 2024
I pushed a change for
ui-toml/max_suggested_slice_pattern_length/index_refutable_slice.rs
above too.17 remaining items
Fix: fixed multipart_suggestion in index_refutable_slice uitest (#13727)
chore: use multipart_suggestion in significant_drop_tightening lint (#…
chore: use multipart_suggestions for match_same_arms (#13803)
unnecessary_to_owned
#13847nanvel commentedon Dec 17, 2024
Hi, a fix for
unnecessary_to_owned
: #13847looking for a review.
scottgerring commentedon Dec 17, 2024
All of these are either done or have an open PR apart from
ui/unnecessary_iter_cloned.rs
which I will knock out tomorrow. @flip1995 , do you mind updating the issue text at the top - I don't think I have that power ?!chore: starting to fix unnecessary_iter_cloned (#13848)
scottgerring commentedon Dec 18, 2024
unnecessary_to_owned
#13847Use multipart suggestion in `unnecessary_to_owned` (#13847)
scottgerring commentedon Dec 20, 2024
All done pending the last two merges 💪
chore: multipart suggestions for let_unit_value lint (#13754)
fix(clippy::manual_assert): use multipart_suggestion instead of span_…