-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Labels
A-cargocargo related issuescargo related issuesA-flycheckissues with flycheck a.k.a. "check on save"issues with flycheck a.k.a. "check on save"A-no_stdissues related to no_std handlingissues related to no_std handlingC-featureCategory: feature requestCategory: feature request
Description
If possible, the option for RA to detect that a crate* is no_std
and disable check.allTargets
, to seamlessly prevent issues like #2142 once and for all, where you can either have RA checking tests where it makes sense, or you can stop bogus errors in no_std
crates, but not both.
*specifically, in my case, I have a VSCode workspace with various cargo crates/workspaces, some no_std
, some not, with per-folder .cargo/config.toml
setting targets.
Alternatively, another option would be do detect no_std
and use a new option, checkOnSave.extraNoStdArgs
, for something like as a (manual) solution. Or both?
{
"rust-analyzer.checkOnSave.allTargets": false,
"rust-analyzer.checkOnSave.extraArgs": [
"--all-targets"
]
"rust-analyzer.checkOnSave.extraNoStdArgs": [
"--bins"
]
}
Metadata
Metadata
Assignees
Labels
A-cargocargo related issuescargo related issuesA-flycheckissues with flycheck a.k.a. "check on save"issues with flycheck a.k.a. "check on save"A-no_stdissues related to no_std handlingissues related to no_std handlingC-featureCategory: feature requestCategory: feature request
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
Veykril commentedon May 26, 2023
Doing this for flycheck (that is cargo check) is kind of tricky right now, as we built the command before we even analyze crates. We'd have to feed back this info after having analyzed all crates which we only do lazily ... So we probably want to change flycheck do built the command on demand.
--all-targets
even ifrust-analyzer.check.allTargets
is false #16859rust-analyzer::flycheck
#18186