Skip to content

Fix beta vs. master differences #15

Open
@Mark-Simulacrum

Description

@Mark-Simulacrum
Member

Despite having added #11, we still saw during the 1.54 beta promotion that master behavior on a particular test seemingly differed from that observed on the beta channel. In particular, rust-lang/rust#86413 was only able to merge with the pgo-branch-weights test disabled, even though this test worked on master at the same time.

We've also been applying patches to workaround non-working tooling (e.g., RLS) on aarch64 MSVC -- rust-lang/rust@c4aeccd only on beta.

Ideally the beta promotion should be much smoother -- without need to backport patches to make it work. We should figure out how to help make this happen, perhaps by adding another -beta builder like we did to fix #11, though this feels a little wasteful.

Activity

pietroalbini

pietroalbini commented on Jun 24, 2021

@pietroalbini
Member

I think we should definitely fix the aarch64 MSVC RLS issue on master too by disabling it.

I'm not sure whether a -beta builder would've actually made a difference in catching the PGO bug: the bug was happening on aarch64, which we aren't testing on stable either.

Mark-Simulacrum

Mark-Simulacrum commented on Jun 24, 2021

@Mark-Simulacrum
MemberAuthor

Oh, I see your point. Perhaps adding a stable builder for aarch64 makes some sense (as the primary other tier 1 arch).

Mark-Simulacrum

Mark-Simulacrum commented on Jun 24, 2021

@Mark-Simulacrum
MemberAuthor

But more broadly, working to make stable/beta builds closer to those on nightly/master seems like a good idea. It's concerning that a test like pgo branch weights even is affected - for unknown at this time reasons - by the beta branch.

pietroalbini

pietroalbini commented on Jun 25, 2021

@pietroalbini
Member

I'm really interested to know why that bug showed up just on beta, and I'm fully on board with adding something to our CI catching similar issues in the future. I wouldn't pre-emptively add other -stable builders for other OSes/archs though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @pietroalbini@Mark-Simulacrum

        Issue actions

          Fix beta vs. master differences · Issue #15 · rust-lang/release-team