do not replace old docs if rebuild failed

[dhardy]

Crate name

rand

Build failure link

https://docs.rs/crate/rand/latest/builds

Additional details

It seems that rand 0.8.5 docs got rebuilt yesterday? Strange; I haven't seen docs.rs just rebuild old docs before. And unfortunately, the rebuild fails due to a nightly feature which got changed since then.

Can you reinstate the old docs build please?

CC rust-random/rand#1528

[GuillaumeGomez]

Changing the issue to "do not replace old docs if rebuild failed".

[syphar]

this is super odd, I actually tested this case and saw that old docs were kept before I started rebuilding...

[syphar]

( reinstanting the old docs is a little tricky, a rebuild would be easier if rand would stop using the fature)

[dhardy]

I can do. I dread to think how many person-hours will be consumed just checking the changelog...

[syphar]

( there might be a quicker way on our side, I probably can look into it tomorrow)

[dhardy]

Would be good. I opened a PR, but the CI is not happy. I guess I could just ignore that. rust-random/rand#1529

[syphar]

@dhardy I was able to restore the docs with some direct SQL hackery in the database.

[dhardy]

Thanks. I'll let you decide whether to close this issue or not (title?).

[syphar]

the issue is still an issue, the title is correct.

[syphar]

@dhardy just a note, we want to do rebuilds so all crates can benefit from the many new rustdoc features,
so there is a value of making rand compile with the current nightly version :)

[dhardy]

I wondered, but didn't see that anywhere.

Rand v0.9 should be out soon.