Skip to content

Consider checking tests in check-only mode #549

Open
@Aaron1011

Description

@Aaron1011
Member

Currently, we only check crates in the workspace for a check-only build:

crater/src/runner/test.rs

Lines 302 to 308 in dcc5456

&[
"check",
"--frozen",
"--all",
"--all-targets",
"--message-format=json",
],

However, we do not pass --tests, which can cause us to miss some regressions. See rust-lang/rust#77789 (comment)

Activity

ehuss

ehuss commented on Jul 16, 2021

@ehuss
Contributor

The --all-targets flag causes it to check all tests.

I don't think crater missed the regression noted in the link. When crater was ran, try_match 0.2.2 was using these dependencies:

proc-macro2 v1.0.18
version_check v0.9.2
unicode-xid v0.2.0
syn v1.0.31
proc-macro-hack v0.5.16
proc-macro-error-attr v1.0.2
proc-macro-error v1.0.2
quote v1.0.7
syn-mid v0.5.0
try_match_inner v0.2.0

With that set, it builds fine. It's only when you update (I'm not sure which) that the regression happens. So it was just a timing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ehuss@Aaron1011

        Issue actions

          Consider checking tests in check-only mode · Issue #549 · rust-lang/crater