Skip to content

Crater skips repositories with a Cargo.toml but not Cargo.lock #548

Open
@Aaron1011

Description

@Aaron1011
Member

When data/github.csv is read, only repositories with both a Cargo.toml and a Cargo.lock are tested:

// Only import repos with a Cargo.toml or Cargo.lock
if !line.has_cargo_toml || !line.has_cargo_lock {
continue;
}

Based on the comment, it looks like the intention was to test repositories with just a Cargo.lock or Cargo.toml as well.

This resulted in a Crater run failing to detect a regression in rust-lang/rust#77718. While Crater cannot be expected to catch all regressions, I think it would be a good idea to test these kinds of repositories. Hopefully, doing so doesn't lead to a significant increase in job run time.

Activity

pietroalbini

pietroalbini commented on Oct 9, 2020

@pietroalbini
Member

The intention of that condition was to filter out libraries already published on crates.io, as there is usually little point in testing multiple versions of the same library. I think it's fine to remove the condition if we implement a more advanced one that still filters out crates published on crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Aaron1011@pietroalbini

        Issue actions

          Crater skips repositories with a Cargo.toml but not Cargo.lock · Issue #548 · rust-lang/crater