Add comment and field checks to test

Author: GideonBature

client/src/client_sync/v17/mod.rs

@@ -252,9 +252,10 @@ pub enum SetBanCommand {
 #[derive(Clone, Debug, Default, Deserialize, PartialEq, Serialize)]
 pub struct ImportMultiRequest {
     /// Descriptor to import. If using descriptor, donot also provide address/scriptPubKey, scripts, or pubkeys.
+    #[serde(default, skip_serializing_if = "Option::is_none")]
     pub desc: Option<String>,
     /// Type of scriptPubKey (string for script, json for address). Should not be provided if using descriptor.
-    #[serde(rename = "scriptPubKey")]
+    #[serde(rename = "scriptPubKey", skip_serializing_if = "Option::is_none")]
     pub script_pub_key: Option<ImportMultiScriptPubKey>,
     /// Creation time of the key expressed in UNIX epoch time, or the string "now" to substitute the current synced blockchain time.
     pub timestamp: ImportMultiTimestamp,

integration_test/tests/wallet.rs

@@ -360,12 +360,14 @@ fn wallet__import_multi() {
     let addr = node.client.new_address().expect("newaddress");
     let dummy_desc = "pkh(02c6047f9441ed7d6d3045406e95c07cd85a2a0e5c1e507a7a7e3d2f0d6c3d8ef8)#tp9h0863";
 
+    // req1: returns success, no warnings nor error.
     let req1 = ImportMultiRequest {
         script_pub_key: Some(ImportMultiScriptPubKey::Script(dummy_script_hex.to_string())),
         timestamp: ImportMultiTimestamp::Now("now".to_string()),
         ..Default::default()
     };
 
+    // req2: returns failure, no warnings, but json-rpc error.
     let req2 = ImportMultiRequest {
         script_pub_key: Some(ImportMultiScriptPubKey::Address {
             address: addr.to_string(),
@@ -374,13 +376,18 @@ fn wallet__import_multi() {
         ..Default::default()
     };
 
+    // req3: returns success, with warnings, no error.
     let req3 = ImportMultiRequest {
         desc: Some(dummy_desc.to_string()),
         timestamp: ImportMultiTimestamp::Time(1_700_000_000),
         ..Default::default()
     };
 
-    let _: ImportMulti = node.client.import_multi(&[req1, req2, req3]).expect("importmulti");
+    let json: ImportMulti = node.client.import_multi(&[req1, req2, req3]).expect("importmulti");
+
+    // checks(result): req2 contain error & req3 contain warnings
+    assert!(json.0[1].error.is_some());
+    assert!(json.0[2].warnings.is_some());
 }
 
 #[test]