Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't serialize Elements that have their default value #121

Open
FreezyLemon opened this issue Apr 4, 2023 · 0 comments
Open

Don't serialize Elements that have their default value #121

FreezyLemon opened this issue Apr 4, 2023 · 0 comments
Labels
enhancement good first issue

Comments

@FreezyLemon
Copy link
Contributor

I noticed this while working on #120.

Required Elements with a default value are not Option<T> in their structs, but just T. We should still avoid serializing them if they're the default Element value. Since we can't use gen_opt etc., there should probably be a new helper function for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FreezyLemon