Add cargo-c to metrics #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look at it soon :)
…On Mon, Nov 11, 2019, 19:38 Luni-4 ***@***.***> wrote:
This PR fixes #28 <#28>
It's a WIP because I wasn't able to run the new cargo-c version
correctly. Sometimes it works and sometimes not, don't know why though. At
the same time, as you can see from the Run cargo-c tests step of the CI,
I got some warnings caused by the new version info feature. Could you tell
me what could be the problem @lu-zero <https://github.com/lu-zero>?
Thanks in advance for your review! :)
------------------------------
You can view, comment on, or merge this pull request online at:
#37
Commit Summary
- Add cargo-c to metrics
File Changes
- *M* .github/workflows/ci-build.yml
<https://github.com/rust-av/av-metrics/pull/37/files#diff-0> (13)
- *M* Cargo.lock
<https://github.com/rust-av/av-metrics/pull/37/files#diff-1> (1)
- *M* av_metrics/Cargo.toml
<https://github.com/rust-av/av-metrics/pull/37/files#diff-2> (5)
- *A* av_metrics/c-example/test.c
<https://github.com/rust-av/av-metrics/pull/37/files#diff-3> (73)
- *A* av_metrics/cbindgen.toml
<https://github.com/rust-av/av-metrics/pull/37/files#diff-4> (7)
- *A* av_metrics/src/capi.rs
<https://github.com/rust-av/av-metrics/pull/37/files#diff-5> (381)
- *M* av_metrics/src/lib.rs
<https://github.com/rust-av/av-metrics/pull/37/files#diff-6> (6)
- *M* av_metrics/src/video/decode/mod.rs
<https://github.com/rust-av/av-metrics/pull/37/files#diff-7> (4)
- *M* av_metrics/src/video/decode/y4m.rs
<https://github.com/rust-av/av-metrics/pull/37/files#diff-8> (14)
Patch Links:
- https://github.com/rust-av/av-metrics/pull/37.patch
- https://github.com/rust-av/av-metrics/pull/37.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37?email_source=notifications&email_token=AAB2LJGIORYBB3I4TWXJ4PDQTEY3FA5CNFSM4JLTUFHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HYL5OHQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB2LJAX5TO4T7HSGAJ765TQTEY3FANCNFSM4JLTUFHA>
.
|
Luni-4
force-pushed
the
cargo-c
branch
8 times, most recently
from
0031de3
to
704b6aa
Compare
|
I've used |
lu-zero
reviewed
Nov 22, 2019
|
I propose to implement the new frame APIs in another PR, so this one can be landed allowing these APIs to be used. What do you think about that @lu-zero? |
Luni-4
force-pushed
the
cargo-c
branch
2 times, most recently
from
6e24137
to
d785b21
Compare
|
I'm fine with that. Fix the rustfmt lints and push :) |
Thanks for your comprehension! :)
Unfortunately, I can't :( To fix the |
|
This sounds a bug in cbindgen. |
Luni-4
force-pushed
the
cargo-c
branch
2 times, most recently
from
638b140
to
e39c250
Compare
|
Go for it, we'll refine later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #28
Sometimes
cargo-cworks and sometimes it doesn't, I don't know why though. Do you know how to fix that @lu-zero?Thanks in advance for your review! :)