Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If in a git repo consider only updating when the file is not dirty? #44

Open
jberryman opened this issue Dec 11, 2023 · 1 comment
Open

Comments

@jberryman
Copy link

I'm wondering if you would accept a change that checked if we were inside a git repo, and if so refuse to update the file if it's dirty or not checked in (the idea being that this is a safer mode of operation). I might try to implement this if you can give me an idea of the design that you'd accept, if you need backwards compatibility or if the default can change, Etc

@bjorn3
Copy link

bjorn3 commented Dec 11, 2023

If you want to keep tests pass for every commit, expect-test necessarily has to be able to update dirty files as the changes that made the file containing the test dirty, likely caused the expected test result to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants