Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Searchbar with some problems when showing results for queries #2530

Closed
3 tasks done
GabrielBittar opened this issue Oct 9, 2024 · 4 comments
Closed
3 tasks done
Assignees
Labels
bug Something isn't working multiple issues priority: medium Modifying an existing feature

Comments

@GabrielBittar
Copy link
Contributor

GabrielBittar commented Oct 9, 2024

Description

The issue

Searchbar is not working fine in some ways. The different problems are listed below (I was on the landing page while processing these searches), as I type the query and simply press Enter, thus passing a query:

  1. Type "Offensive Security" or "C Programming", for example = opens up a search page with only a few links and with the search query rawly displayed in the place of the Category name. Also, the informations in the info button won't show any description on hover.
  2. Type "Web Security" = a page with the description "Resources [...] Couldn't find what you're looking for? Feel free to seek
    assistance in our Discord community." appears, also with the search query displayed in the place of the category and the info button won't display description on hover.
  3. Type "javascript" = 404 not found (although there are many links with "javascript" on title)

Btw, for the seemingly right way: type "Authentication" ou "authentication" and see the results: this seems to be the right way to display them.

Changes proposed

  1. Fix the bugs described (info buttons, 404 for JS and search queries displaying on interface)"
  2. I suggest we also start considering at least category name matches for the search, with results by category appearing after the results which matched by links. This would prevent cases like item 2 (Web Security), which really has no links with "web security" on title, but has a lot of links under this category, or like "Offensive Security", which shows only one link. Imo, it should show in order: A) Links matching the text typed on searchbar; B) Links under categories matching the text typed.

I'm interested in being assigned to work on this.

Checklist

  • I have checked the existing issues
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (optional)
@GabrielBittar GabrielBittar added bug Something isn't working priority: medium Modifying an existing feature labels Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

#2527, #2501 is already opened by you
As per contributing guidelines, you can only work on 1 issue at a time.

Copy link

github-actions bot commented Oct 9, 2024

Hello GabrielBittar!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

@rupali-codes
Copy link
Owner

Thank you for noticing, assigning it to you, let me know if you need any help

@GabrielBittar
Copy link
Contributor Author

Thank you for noticing, assigning it to you, let me know if you need any help

Thanks, I'll start working on it now. Btw, also noticed Design Color Tools is without a description, from issue #2501 . I'll also fix it in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working multiple issues priority: medium Modifying an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants