Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript should be a normal (not dev) dependency #72

Open
blittle opened this issue Jun 2, 2021 · 1 comment
Open

typescript should be a normal (not dev) dependency #72

blittle opened this issue Jun 2, 2021 · 1 comment

Comments

@blittle
Copy link

blittle commented Jun 2, 2021

The lib/index.cjs.js artifact has a direct dependency on typescript (see line 3), which means this should have a direct dependency on typescript, instead of dev dependency. The problem is manifest with the warning when using yarn2:

Error: ts-simple-type tried to access typescript, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
@justinfagnani
Copy link
Collaborator

I wonder if it's intended to be a peer dependency. I'm updating TypeScript now, but not changing this yet while I figure out how things are structured...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants