Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobExecutionDelete job ID type should be string #2

Open
alexthehurst opened this issue May 18, 2020 · 1 comment · May be fixed by #5
Open

jobExecutionDelete job ID type should be string #2

alexthehurst opened this issue May 18, 2020 · 1 comment · May be fixed by #5

Comments

@alexthehurst
Copy link

This is integer in the current spec file, but it should be updated to string to match the rest of the job endpoints that provide job ID.

https://github.com/rundeck/rundeck-api-specs/blob/master/rundeck/job.yaml#L117
@alexthehurst alexthehurst mentioned this issue May 18, 2020
Open
@elda27 elda27 linked a pull request May 7, 2022 that will close this issue
Open
@elda27
Copy link

elda27 commented May 7, 2022

I'm reading the JSON response instead of XML response.
And I found a type of id is obtained integer.
Maybe id of executions should be integer instead of string.
And the following type of id is wrong too.

rundeck-api-specs/rundeck/job.yaml

Line 117 in 1ca031c

type: integer 

{
  "paging": {
    "count": 1,
    "total": 1,
    "offset": 0,
    "max": 20
  },
  "executions": [
    {
      "id": 69,
      "href": "http://127.0.0.1:4440/api/41/execution/69",
      "permalink": "http://127.0.0.1:4440/project/9d8a022e03f84edb8c4841fb4bebab17/execution/show/69",
      "status": "running",
      "project": "9d8a022e03f84edb8c4841fb4bebab17",
      "executionType": "user",
      "user": "admin",
      "date-started": {
        "unixtime": 1651941065564,
        "date": "2022-05-07T16:31:05Z"
      },
      "job": {
        "id": "72274b48-2661-4052-bfbf-ed4460727c9e",
        "name": "Test job",
        "group": "",
        "project": "9d8a022e03f84edb8c4841fb4bebab17",
        "description": "Test job description",
        "href": "http://127.0.0.1:4440/api/41/job/72274b48-2661-4052-bfbf-ed4460727c9e",
        "permalink": "http://127.0.0.1:4440/project/9d8a022e03f84edb8c4841fb4bebab17/job/show/72274b48-2661-4052-bfbf-ed4460727c9e"
      },
      "description": "echo $(date) [... 4 steps]",
      "argstring": null,
      "serverUUID": "a14bc3e6-75e8-4fe4-a90d-a16dcc976bf6"
    }
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix type of executionId due to incompatible with api arguments elda27/rundeck-api-specs
2 participants
@elda27 @alexthehurst