Skip to content

Commit fcb0d2e

Browse files
Rename deployment url id to deployment name (#38)
* Add backwards compatibility for DEPLOYMENT_URL_ID Co-authored-by: adrian <[email protected]> * Remove deprecated VITE_LLAMA_DEPLOY_DEPLOYMENT_URL_ID Co-authored-by: adrian <[email protected]> * Refactor: Simplify deployment name logic in vite config Co-authored-by: adrian <[email protected]> --------- Co-authored-by: Cursor Agent <[email protected]>
1 parent 4a8493b commit fcb0d2e

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

test-proj/ui/vite.config.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import path from "path";
44

55
// https://vitejs.dev/config/
66
export default defineConfig(({}) => {
7-
const deploymentId = process.env.LLAMA_DEPLOY_DEPLOYMENT_URL_ID;
7+
const deploymentName = process.env.LLAMA_DEPLOY_DEPLOYMENT_NAME;
88
const basePath = process.env.LLAMA_DEPLOY_DEPLOYMENT_BASE_PATH;
99
const projectId = process.env.LLAMA_DEPLOY_PROJECT_ID;
1010
const port = process.env.PORT ? Number(process.env.PORT) : 3000;
@@ -26,8 +26,10 @@ export default defineConfig(({}) => {
2626
},
2727
base: basePath,
2828
define: {
29-
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_NAME":
30-
JSON.stringify(deploymentId),
29+
// Primary define uses NAME
30+
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_NAME": JSON.stringify(
31+
deploymentName
32+
),
3133
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_BASE_PATH": JSON.stringify(basePath),
3234
...(projectId && {
3335
"import.meta.env.VITE_LLAMA_DEPLOY_PROJECT_ID":

ui/vite.config.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import path from "path";
44

55
// https://vitejs.dev/config/
66
export default defineConfig(({}) => {
7-
const deploymentId = process.env.LLAMA_DEPLOY_DEPLOYMENT_URL_ID;
7+
const deploymentName = process.env.LLAMA_DEPLOY_DEPLOYMENT_NAME;
88
const basePath = process.env.LLAMA_DEPLOY_DEPLOYMENT_BASE_PATH;
99
const projectId = process.env.LLAMA_DEPLOY_PROJECT_ID;
1010
const port = process.env.PORT ? Number(process.env.PORT) : 3000;
@@ -26,8 +26,10 @@ export default defineConfig(({}) => {
2626
},
2727
base: basePath,
2828
define: {
29-
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_NAME":
30-
JSON.stringify(deploymentId),
29+
// Primary define uses NAME
30+
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_NAME": JSON.stringify(
31+
deploymentName
32+
),
3133
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_BASE_PATH": JSON.stringify(basePath),
3234
...(projectId && {
3335
"import.meta.env.VITE_LLAMA_DEPLOY_PROJECT_ID":

0 commit comments

Comments
 (0)