Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Dark Mode #5

Open
rumaan opened this issue Oct 8, 2019 · 2 comments
Open

Support for Dark Mode #5

rumaan opened this issue Oct 8, 2019 · 2 comments
Labels
good first issue Good for newcomers hacktoberfest Contributions to Hacktoberfest

Comments

@rumaan
Copy link
Owner

rumaan commented Oct 8, 2019

  • Support for Switching between dark and light modes
  • Also better colours (changing the app bar/ background colour based on the image)
@rumaan rumaan added good first issue Good for newcomers hacktoberfest Contributions to Hacktoberfest labels Oct 8, 2019
@rumaan rumaan changed the title Dark Mode Toggle Support for Dark Mode Oct 8, 2019
@lvlasuod
Copy link

Hey, may I work on this issue?

@rumaan
Copy link
Owner Author

rumaan commented Oct 15, 2019

Hey, may I work on this issue?

There was one more person working on this. I'll wait for next 2 days for their PR on this. If none, then you are clear to go ahead with this.

I dark mode toggle switch in the app bar would be ideal and please make sure you de-couple to logic which toggles the theme and the UI into separate classes/files because it might be moved somewhere else in the later stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest Contributions to Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lvlasuod @rumaan