Fix typos in design.md #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui314
force-pushed
the
main
branch
5 times, most recently
from
c008ee2 to
cfccfc2
Compare
rui314
force-pushed
the
main
branch
2 times, most recently
from
20d1729 to
2464a55
Compare
rui314
force-pushed
the
main
branch
3 times, most recently
from
28b2820 to
7a8c14a
Compare
rui314
force-pushed
the
main
branch
3 times, most recently
from
803547d to
8f0acbf
Compare
|
this PR seems good |
rui314
force-pushed
the
main
branch
4 times, most recently
from
f797b76 to
a44de89
Compare
rui314
force-pushed
the
main
branch
10 times, most recently
from
5ca2bb9 to
708ad63
Compare
rui314
force-pushed
the
main
branch
3 times, most recently
from
4652763 to
230976a
Compare
rui314
force-pushed
the
main
branch
2 times, most recently
from
192efa1 to
a1711b9
Compare
rui314
force-pushed
the
main
branch
3 times, most recently
from
ccf2cda to
7d91674
Compare
rui314
force-pushed
the
main
branch
2 times, most recently
from
bf2c440 to
df9e997
Compare
rui314
force-pushed
the
main
branch
2 times, most recently
from
1ca7b17 to
d6db850
Compare
|
There's another typo, seems like this PR hasn't been covered yet. |
|
I don't really care too much about typos in the comments and these supplemental documents that are intended to be read only by developers. |
|
@rui314 Is there a reason not merge this? When people find typos, they are willing try to help the project. Just merging them would be the easiest for you, wouldn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Sattler [email protected]