Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vulnerabilities in dependencies #157

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Nov 5, 2024

Description of the change

https://linear.app/rudderstack/issue/SDK-2575/address-vulnerabilities-in-node-sdk

I've updated all the dependencies to the latest.

Some notable changes:

  • Upgrade Node to the latest version.
  • Removed unwanted Babel dependencies.
  • Formatted and fixed lint issues in the code.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@saikumarrs saikumarrs self-assigned this Nov 5, 2024
@saikumarrs saikumarrs requested a review from MoumitaM as a code owner November 5, 2024 08:12
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 10 lines in your changes missing coverage. Please review.

Project coverage is 51.26%. Comparing base (232b33c) to head (36be354).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/loosely-validate-event/index.js 68.75% 0 Missing and 10 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #157      +/-   ##
===========================================
+ Coverage    50.70%   51.26%   +0.56%     
===========================================
  Files            3        3              
  Lines          355      355              
  Branches        80       80              
===========================================
+ Hits           180      182       +2     
+ Misses         115      113       -2     
  Partials        60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@MoumitaM MoumitaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tested if the SDK is building properly with the new changes?

index.d.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 6, 2024

@saikumarrs saikumarrs merged commit c4e472c into develop Nov 6, 2024
11 checks passed
@saikumarrs saikumarrs deleted the feat.fix-vulnerabilities-sdk-2575 branch November 6, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants