Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add date datatype #154

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

MoumitaM
Copy link

@MoumitaM MoumitaM commented Nov 1, 2024

Description of the change

Allow date data type in context, traits, and properties

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@MoumitaM MoumitaM requested a review from saikumarrs as a code owner November 1, 2024 06:43
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.70%. Comparing base (bee4fcf) to head (54c1432).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #154   +/-   ##
========================================
  Coverage    50.70%   50.70%           
========================================
  Files            3        3           
  Lines          355      355           
  Branches        80       80           
========================================
  Hits           180      180           
  Misses         115      115           
  Partials        60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoumitaM
Copy link
Author

MoumitaM commented Nov 1, 2024

Created a task in the backlog to address vulnerabilities.

index.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@saikumarrs saikumarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes

@MoumitaM MoumitaM requested a review from saikumarrs November 4, 2024 04:05
Copy link

sonarcloud bot commented Nov 4, 2024

@MoumitaM MoumitaM merged commit cf714ae into develop Nov 4, 2024
11 of 12 checks passed
@MoumitaM MoumitaM deleted the feat/SDK-2557-add-date-datatype branch November 4, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants