Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logout endpoint tries to render non-existent view in some cases #227

Open
davexunit opened this issue Oct 24, 2014 · 0 comments · May be fixed by #228
Open

Logout endpoint tries to render non-existent view in some cases #227

davexunit opened this issue Oct 24, 2014 · 0 comments · May be fixed by #228

Comments

@davexunit
Copy link
Contributor

The end of the logout endpoint code in lib/casserver/server.rb, there's the following if block:

      if @gateway && @service
        redirect @service, 303
      elsif @continue_url
        render @template_engine, :logout
      else
        render @template_engine, :login
      end

The middle condition attempts to render a view that doesn't exist. Is this intentional? Are users expected to write a custom logout view? If not, would it make sense to redirect to @continue_url instead?
@davexunit davexunit linked a pull request Oct 24, 2014 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

logout: Redirect to continue_url when present. davexunit/rubycas-server
1 participant
@davexunit