Fix Resolv#initialize signature: array of resolvers + use_ipv6:#2960
Merged
Conversation
`Resolv#initialize` took `?Resolv::Hosts | Resolv::DNS resolvers`, which is wrong on two counts, both visible in this file's own RD doc (`new(resolvers=..., use_ipv6: ...)`): - `resolvers` is the resolver *list*, not a single resolver — Ruby's implementation iterates it (`@resolvers.each`). Passing one resolver object fails at runtime. It accepts an Array of resolver objects, a Hash (used as DNS-resolver configuration, per the doc), or nil. - the `use_ipv6:` keyword was missing from the signature entirely.
Collaborator
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolv#initializetook?Resolv::Hosts | Resolv::DNS resolvers, which is wrong on two counts, both visible in this file's own RD doc (new(resolvers=..., use_ipv6: ...)):resolversis the resolver list, not a single resolver — Ruby's implementation iterates it (@resolvers.each). Passing one resolver object fails at runtime. It accepts an Array of resolver objects, a Hash (used as DNS-resolver configuration, per the doc), or nil.use_ipv6:keyword was missing from the signature entirely.See https://github.com/ruby/ruby/blob/v4.0.5/lib/resolv.rb#L82-L100