Skip to content

Commit 90ab06b

Browse files
authored
Merge pull request #140 from ruby/fix-regression-139
Fix dependency task for Rake::TestTask
2 parents 7ff501a + 4c7bb86 commit 90ab06b

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

lib/rake/testtask.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,10 @@ def initialize(name=:test)
9393
@ruby_opts = []
9494
@description = "Run tests" + (@name == :test ? "" : " for #{@name}")
9595
@deps = []
96+
if @name.is_a?(Hash)
97+
@deps = @name.values
98+
@name = @name.keys.first
99+
end
96100
yield self if block_given?
97101
@pattern = 'test/test*.rb' if @pattern.nil? && @test_files.nil?
98102
define

test/test_rake_test_task.rb

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,15 @@ def test_initialize
1616
assert Task.task_defined?(:test)
1717
end
1818

19+
def test_initialize_deps
20+
tt = Rake::TestTask.new(:example => :bar)
21+
refute_nil tt
22+
assert_equal [:bar], tt.deps
23+
assert Task.task_defined?(:example)
24+
end
25+
1926
def test_initialize_override
20-
tt = Rake::TestTask.new(:example) do |t|
27+
tt = Rake::TestTask.new(:example => :bar) do |t|
2128
t.description = "Run example tests"
2229
t.libs = ['src', 'ext']
2330
t.pattern = 'test/tc_*.rb'

0 commit comments

Comments
 (0)