Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject assigning command call without parentheses #3245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reject assigning command call without parentheses #3245

wants to merge 1 commit into from

Conversation

ydah
Copy link
Contributor

@ydah ydah commented Nov 27, 2024

Fixes: #3106

@ydah ydah force-pushed the reject-assigning-command-call-without-parentheses branch 5 times, most recently from 7e133b9 to 57038f1 Compare December 3, 2024 13:48
@ydah ydah force-pushed the reject-assigning-command-call-without-parentheses branch from 57038f1 to b045ab4 Compare December 3, 2024 13:48
@eileencodes
Copy link
Member

It looks like this change has a legit test failure, can you take a look?

kddnewton
kddnewton requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@kddnewton kddnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is something we'll want to fix with the accepts_command_call variable as opposed to validating later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kddnewton kddnewton kddnewton requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assigning command call is allowed where rejected in parse.y
3 participants
@ydah @eileencodes @kddnewton