Prefer to use RTEST when checking result of rb_io_wait. (#5341)

ioquatix · web-flow · commit 14b51ba80f99 · 2021-12-25T02:26:06.000+13:00
* Prefer to use RTEST when checking result of `rb_io_wait`.

* Consistently use false for signifying no events ready.
diff --git a/ext/io/console/console.c b/ext/io/console/console.c
@@ -556,7 +556,7 @@ console_getch(int argc, VALUE *argv, VALUE io)
 	    if (!(w & RB_WAITFD_IN)) return Qnil;
 # else
 	    VALUE result = rb_io_wait(io, RUBY_IO_READABLE, timeout);
-	    if (result == Qfalse) return Qnil;
+	    if (!RTEST(result)) return Qnil;
 # endif
 	}
 	else if (optp->vtime) {

Original file line number	Diff line number	Diff line change
`@@ -556,7 +556,7 @@ console_getch(int argc, VALUE *argv, VALUE io)`
`556`	`556`	`if (!(w & RB_WAITFD_IN)) return Qnil;`
`557`	`557`	`# else`
`558`	`558`	`VALUE result = rb_io_wait(io, RUBY_IO_READABLE, timeout);`
`559`		`- if (result == Qfalse) return Qnil;`
	`559`	`+ if (!RTEST(result)) return Qnil;`
`560`	`560`	`# endif`
`561`	`561`	`}`
`562`	`562`	`else if (optp->vtime) {`