fixed problem with bang method due to refactoring - all specs pass

Author: catmando

Rakefile

@@ -4,15 +4,15 @@ require "rspec/core/rake_task"
 
 
 task :spec do
-  (1..6).each { |batch| Rake::Task["spec:batch#{batch}"].invoke rescue nil }
+  (1..7).each { |batch| Rake::Task["spec:batch#{batch}"].invoke rescue nil }
 end
 
 namespace :spec do
   task :prepare do
     sh %{bundle update}
     sh %{cd spec/test_app; bundle update; bundle exec rails db:setup} # may need ;bundle exec rails db:setup as well
   end
-  (1..6).each do |batch|
+  (1..7).each do |batch|
     RSpec::Core::RakeTask.new(:"batch#{batch}") do |t|
       t.pattern = "spec/batch#{batch}/**/*_spec.rb"
     end

lib/reactive_record/active_record/reactive_record/setters.rb

@@ -81,23 +81,27 @@ def set_common(attr, value)
     end
 
     def set_attribute_change_status_and_notify(attr, changed, new_value)
-      @attributes[attr] = new_value
-      change_status_and_notify_helper(attr, changed) do |had_key, current_value|
-        if !data_loading? ||
-           (on_opal_client? && had_key && current_value.loaded? && current_value != new_value)
-          React::State.set_state(self, attr, new_value, data_loading?)
+      if @virgin
+        @attributes[attr] = new_value
+      else
+        change_status_and_notify_helper(attr, changed) do |had_key, current_value|
+          @attributes[attr] = new_value
+          if !data_loading? ||
+             (on_opal_client? && had_key && current_value.loaded? && current_value != new_value)
+            React::State.set_state(self, attr, new_value, data_loading?)
+          end
         end
       end
     end
 
     def set_change_status_and_notify_only(attr, changed)
+      return if @virgin
       change_status_and_notify_helper(attr, changed) do
         React::State.set_state(self, attr, nil) unless data_loading?
       end
     end
 
     def change_status_and_notify_helper(attr, changed)
-      return if @virgin
       empty_before = changed_attributes.empty?
       if !changed
         changed_attributes.delete(attr)

spec/batch1/misc/ar_basics_tbdspec.rb

@@ -0,0 +1,120 @@
+require 'spec_helper'
+require 'test_components'
+require 'rspec-steps'
+
+RSpec::Steps.steps "AR Client Basics", js: true do
+
+  before(:all) do
+    on_client do
+
+      class BaseClass < ActiveRecord::Base
+        self.abstract_class = true
+      end
+
+      class SubClass < BaseClass
+      end
+
+      class SubSubClass < SubClass
+      end
+
+      class Funky < ActiveRecord::Base
+        self.primary_key = :funky_id
+        self.inheritance_column = :funky_type
+      end
+
+      class BelongsTo < ActiveRecord::Base
+        belongs_to :has_many
+        belongs_to :has_one
+        belongs_to :best_friend, class_name: "HasMany", foreign_key: :bf_id
+      end
+
+      class HasMany < ActiveRecord::Base
+        has_many :belongs_to
+        has_many :best_friends, class_name: "BelongsTo", foreign_key: :bf_id
+      end
+
+      class HasOne < ActiveRecord::Base
+        has_one :belongs_to
+      end
+
+      class Scoped < ActiveRecord::Base
+        scope :only_those_guys, -> () {}
+      end
+    end
+  end
+
+  it "will find the base class" do
+    expect_evaluate_ruby("SubSubClass.base_class").to eq("SubClass")
+  end
+
+  it "knows the primary key" do
+    expect_evaluate_ruby("BaseClass.primary_key").to eq("id")
+  end
+
+  it "can override the primary key" do
+    expect_evaluate_ruby("Funky.primary_key").to eq("funky_id")
+  end
+
+  it "knows the inheritance column" do
+    expect_evaluate_ruby('BaseClass.inheritance_column').to eq('type')
+  end
+
+  it "can override the inheritance column" do
+    expect_evaluate_ruby('Funky.inheritance_column').to eq('funky_type')
+  end
+
+  it "knows the model name" do
+    expect_evaluate_ruby('BaseClass.model_name').to eq("BaseClass")
+  end
+
+  it "can find a record by id" do
+    expect_evaluate_ruby('BaseClass.find(12).id').to eq(12)
+  end
+
+  it "has a find_by_xxx method" do
+    expect_evaluate_ruby('BaseClass.find_by_xxx("beer").xxx').to eq("beer")
+  end
+
+  it "will correctly infer the model type from the inheritance column" do
+    expect_evaluate_ruby('BaseClass.find_by_type("SubClass").class').to eq('SubClass')
+    expect_evaluate_ruby('BaseClass.find_by_type(nil).class').to eq('BaseClass')
+  end
+
+  it "can have a has_many association" do
+    expect_evaluate_ruby(HasMany.reflect_on_association(:belongs_to).klass.reflect_on_association(:has_many).klass).to eq(HasMany)
+  end
+
+  it "can have a has_one association" do
+    expect_evaluate_ruby(HasOne.reflect_on_association(:belongs_to).klass.reflect_on_association(:has_one).klass).to eq(HasOne)
+  end
+
+  it "can override the class and foreign_key values when creating an association" do
+    reflection = HasMany.reflect_on_association(:best_friends)
+    expect_evaluate_ruby(reflection.klass).to eq(BelongsTo)
+    expect_evaluate_ruby(reflection.association_foreign_key).to eq(:bf_id)
+  end
+
+  it "can have a scoping method" do
+    expect_evaluate_ruby(Scoped.only_those_guys.respond_to? :all).to be_truthy
+  end
+
+  it "can type check parameters" do
+    expect_evaluate_ruby(SubClass._react_param_conversion({attr1: 1, attr2: 2, type: "SubClass", id: 123}.to_n, :validate_only)).to be(true)
+  end
+
+  it "can type check parameters with native wrappers" do
+    expect_evaluate_ruby(SubClass._react_param_conversion(Native({attr1: 1, attr2: 2, type: "SubClass", id: 123}.to_n), :validate_only)).to be(true)
+  end
+
+  it "will fail type checking if type does not match" do
+    expect_evaluate_ruby(SubClass._react_param_conversion({attr1: 1, attr2: 2, type: nil, id: 123}.to_n, :validate_only)).to be_falsy
+  end
+
+  it "will convert a hash to an instance" do
+    ar = SubClass._react_param_conversion({attr1: 1, attr2: 2, type: "SubClass", id: 123}.to_n)
+    expect_evaluate_ruby(ar.attr1).to eq(1)
+    expect_evaluate_ruby(ar.attr2).to eq(2)
+    expect_evaluate_ruby(ar.id).to eq(123)
+  end
+
+end

spec/batch1/misc/validate_spec.rb

@@ -3,7 +3,7 @@
 require 'rspec-steps'
 
 
-RSpec::Steps.steps "access like a hash", js: true do
+RSpec::Steps.steps "validate and valid? methods", js: true do
 
   before(:step) do
     # spec_helper resets the policy system after each test so we have to setup

spec/batch2/non_ar_aggregations_tbdspec.rb

@@ -0,0 +1,109 @@
+require 'spec_helper'
+require 'rspec-steps'
+
+RSpec::Steps.steps 'using non-ar aggregations', js: true do
+
+  before(:each) do
+    require 'pusher'
+    require 'pusher-fake'
+    Pusher.app_id = "MY_TEST_ID"
+    Pusher.key =    "MY_TEST_KEY"
+    Pusher.secret = "MY_TEST_SECRET"
+    require "pusher-fake/support/base"
+
+    Hyperloop.configuration do |config|
+      config.transport = :pusher
+      config.channel_prefix = "synchromesh"
+      config.opts = {app_id: Pusher.app_id, key: Pusher.key, secret: Pusher.secret}.merge(PusherFake.configuration.web_options)
+    end
+
+    User.do_not_synchronize
+  end
+
+  before(:step) do
+    stub_const 'TestApplicationPolicy', Class.new
+    TestApplicationPolicy.class_eval do
+      always_allow_connection
+      regulate_all_broadcasts { |policy| policy.send_all }
+      allow_change(to: :all, on: [:create, :update, :destroy]) { true }
+    end
+    ApplicationController.acting_user = nil
+  end
+
+  it "create an aggregation" do
+    expect_evaluate_ruby do
+      User.new(first_name: "Data", data: TestData.new("hello", 3)).data.big_string
+    end.to eq("hellohellohello")
+  end
+
+  it "save it" do
+    evaluate_promise do
+      User.find_by_first_name("Data").save
+    end
+    expect(User.find_by_first_name("Data").data.big_string).to eq("hellohellohello")
+    binding.pry
+  end
+
+  it "read it" do
+    User.create(first_name: 'User2', data: TestData.new('goodby', 3))
+    expect_promise do
+      ReactiveRecord.load { User.find_by_first_name("User2").data.big_string }
+    end.to eq('goodbygoodbygoodby')
+  end
+
+  # and restored ...
+  #
+  # async "is time to change it, and force the save" do
+  #   user = User.find_by_first_name("Data")
+  #   user.data.string = "goodby"
+  #   user.save(force: true).then do
+  #     React::IsomorphicHelpers.load_context
+  #     ReactiveRecord.load do
+  #       User.find_by_first_name("Data").data
+  #     end.then do |data|
+  #       async { expect(data.big_string).to eq("goodbygoodbygoodby") }
+  #     end
+  #   end
+  # end
+  #
+  # async "is time to change the value completely and save it (no force needed)" do
+  #   user = User.find_by_first_name("Data")
+  #   user.data = TestData.new("the end", 1)
+  #   user.save.then do
+  #     React::IsomorphicHelpers.load_context
+  #     ReactiveRecord.load do
+  #       User.find_by_first_name("Data").data
+  #     end.then do |data|
+  #       async { expect(data.big_string).to eq("the end") }
+  #     end
+  #   end
+  # end
+  #
+  # async "is time to delete the value and see if returns nil after saving" do
+  #   user = User.find_by_first_name("Data")
+  #   user.data = nil
+  #   user.save.then do
+  #     React::IsomorphicHelpers.load_context
+  #     ReactiveRecord.load do
+  #       User.find_by_first_name("Data").data
+  #     end.then do |data|
+  #       async { expect(data).to be_nil }
+  #     end
+  #   end
+  # end
+  #
+  # it "is time to delete our user" do
+  #   User.find_by_first_name("Data").destroy.then do
+  #     expect(User.find_by_first_name("Data")).to be_destroyed
+  #   end
+  # end
+  #
+  # it "is time to see to make sure a nil aggregate that has never had a value returns nil" do
+  #   ReactiveRecord.load do
+  #     User.find_by_email("[email protected]").data
+  #   end.then do |data|
+  #     expect(data).to be_nil
+  #   end
+  # end
+
+end

spec/batch6/server_method_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+require 'rspec-steps'
+
+RSpec::Steps.steps 'server_method', js: true do
+
+  before(:each) do
+    require 'pusher'
+    require 'pusher-fake'
+    Pusher.app_id = "MY_TEST_ID"
+    Pusher.key =    "MY_TEST_KEY"
+    Pusher.secret = "MY_TEST_SECRET"
+    require "pusher-fake/support/base"
+
+    Hyperloop.configuration do |config|
+      config.transport = :pusher
+      config.channel_prefix = "synchromesh"
+      config.opts = {app_id: Pusher.app_id, key: Pusher.key, secret: Pusher.secret}.merge(PusherFake.configuration.web_options)
+    end
+
+    #User.do_not_synchronize
+  end
+
+  before(:step) do
+    stub_const 'TestApplicationPolicy', Class.new
+    TestApplicationPolicy.class_eval do
+      always_allow_connection
+      regulate_all_broadcasts { |policy| policy.send_all }
+      allow_change(to: :all, on: [:create, :update, :destroy]) { true }
+    end
+    ApplicationController.acting_user = nil
+  end
+
+  it "can call a server method" do
+    isomorphic do
+      TodoItem.class_eval do
+        class << self
+          attr_writer :server_method_count
+
+          def server_method_count
+            @server_method_count ||= 0
+          end
+        end
+        server_method(:test, default: 0) { TodoItem.server_method_count += 1 }
+      end
+    end
+    TodoItem.create
+    mount 'ServerMethodTester' do
+      class ServerMethodTester < Hyperloop::Component
+        render(DIV) do
+          "test = #{TodoItem.first.test}"
+        end
+      end
+    end
+    expect(page).to have_content('test = 1')
+  end
+
+  it "can update the server method" do
+    evaluate_ruby("TodoItem.first.test!")
+    expect(page).to have_content('test = 2')
+  end
+
+  it "when updating the server method it returns the current value while waiting for the promise" do
+    expect_evaluate_ruby("TodoItem.first.test!").to eq(2)
+  end
+
+  it "returns the default value on the first call while waiting for the promise" do
+    expect_evaluate_ruby("TodoItem.new.test").to eq(0)
+  end
+
+  it "works with the load method" do
+    expect_promise do
+      new_todo = TodoItem.new
+      ReactiveRecord.load do
+        new_todo.test
+      end
+    end.to eq(5)
+  end
+end