Check for background script breaks for more complicated output.filename rules

[tfedor]

Type:

• bug
• feature
• enhancement
• question

Environment:

• OS: Independent
• Browser: Independent
• Library Version: 1.1.4

I'm going to open a PR:

• yes
• no

Description:

I was getting error #WER-E1, so I went investigating, and I found out piece of code starting here can't work with more complicated output.filename rules:

webpack-extension-reloader/src/utils/manifest.ts

Line 29 in 4f9aa5e

const toRemove = (filename as string).replace("[name]", "");

Consider following:

// manifest
background.scripts: "js/background.js";

// webpack
entry: { background: "..." }
output.filename: "js/[name].js"

When we reach entries check on line 29, what happens is we will get replace rule js/.js, which obviously can't work as expected.

I would suggest replacing that check with somethinig like this:

  const bgWebpackEntry = Object.keys(webpackEntry).find(entryName =>
    bgScriptFileNames.some(
      bgManifest => filename.replace("[name]", entryName) === bgManifest,
    ),
  );