Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the host of the WS server be configurable? #102

Open
2 of 6 tasks
amahouachi opened this issue Apr 17, 2020 · 0 comments
Open
2 of 6 tasks

Can the host of the WS server be configurable? #102

amahouachi opened this issue Apr 17, 2020 · 0 comments

Comments

@amahouachi
Copy link

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Linux (running the server)/Windows (running the browser)
  • Browser: Chrome
  • Library Version: 1.1.4

I'm going to open a PR:

  • yes
  • no

Description:
The port on which the server is listening is configurable. But the host is hardcoded as "localhost"
This is a problem in a configuration where the dev environment and the build runtime environment is on one machine while the browser where the extension is being loaded is on another marchine.

The extension reloader is not able to reach ws://localhost:port since the server is listening on another machine.

Can the host be a configuration parameter just like the port ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant