Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve paths from perspective of config file rather than working directory #27

Open
rubenchristoffer opened this issue May 27, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rubenchristoffer
Copy link
Owner

rubenchristoffer commented May 27, 2020

Currently relative paths are resolved from the perspective of the working directory and not the actual config file. That can lead to trouble when specifying a config file that resides in a different directory than the working directory.

Here's an example of the problem:
Working directory is "/home/user".
Config file is "/home/user/config/config.linker"

If the config has a relative target path "./linkhere" and you run the command mklinker linkall --path /home/user/config/config.linker, then the actual link will be created in "/home/user/linkhere" rather than "/home/user/config/linkhere".

@rubenchristoffer rubenchristoffer changed the title Make LinkAll use path relative to config file Make LinkAll use path relative to config file when resolving relative paths May 27, 2020
@rubenchristoffer rubenchristoffer added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 29, 2020
@rubenchristoffer rubenchristoffer changed the title Make LinkAll use path relative to config file when resolving relative paths Resolve paths from perspective of config file rather than working directory May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant