Skip to content

Commit 9716496

Browse files
retailcoderretailcoder
authored
Merge pull request #6029 from GmausDev/issue5723
Issue #5723
2 parents 5243300 + 78e9382 commit 9716496

File tree

13 files changed

+178
-180
lines changed

13 files changed

+178
-180
lines changed

‎Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ public enum CodeInspectionType
44
{
55
RubberduckOpportunities,
66
LanguageOpportunities,
7-
MaintainabilityAndReadabilityIssues,
7+
NamingAndConventionsIssues,
88
CodeQualityIssues,
99
Performance,
10+
Uncategorized,
1011
}
1112
}

‎Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.Designer.cs‎

Lines changed: 124 additions & 127 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.settings‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<Value Profile="(Default)">&lt;?xml version="1.0" encoding="utf-16"?&gt;
77
&lt;CodeInspectionSettings xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"&gt;
88
&lt;CodeInspections&gt;
9-
&lt;CodeInspection Name="BooleanAssignedInIfElseInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
9+
&lt;CodeInspection Name="BooleanAssignedInIfElseInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
1010
&lt;CodeInspection Name="ObsoleteErrorSyntaxInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
1111
&lt;CodeInspection Name="StopKeywordInspection" Severity="Suggestion" InspectionType="CodeQualityIssues" /&gt;
1212
&lt;CodeInspection Name="UnhandledOnErrorResumeNextInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
@@ -18,52 +18,52 @@
1818
&lt;CodeInspection Name="AttributeOutOfSyncInspection" Severity="Warning" InspectionType="RubberduckOpportunities" /&gt;
1919
&lt;CodeInspection Name="MissingAnnotationArgumentInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
2020
&lt;CodeInspection Name="ModuleScopeDimKeywordInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
21-
&lt;CodeInspection Name="MultilineParameterInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
22-
&lt;CodeInspection Name="MultipleDeclarationsInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
21+
&lt;CodeInspection Name="MultilineParameterInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
22+
&lt;CodeInspection Name="MultipleDeclarationsInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
2323
&lt;CodeInspection Name="ObsoleteCallStatementInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
2424
&lt;CodeInspection Name="ObsoleteCommentSyntaxInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
2525
&lt;CodeInspection Name="ObsoleteLetStatementInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
26-
&lt;CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
26+
&lt;CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" /&gt;
2727
&lt;CodeInspection Name="RedundantOptionInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
2828
&lt;CodeInspection Name="OptionExplicitInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
2929
&lt;CodeInspection Name="ProcedureCanBeWrittenAsFunctionInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
3030
&lt;CodeInspection Name="ApplicationWorksheetFunctionInspection" Severity="Suggestion" InspectionType="CodeQualityIssues" /&gt;
3131
&lt;CodeInspection Name="AssignedByValParameterInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
32-
&lt;CodeInspection Name="EmptyModuleInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
32+
&lt;CodeInspection Name="EmptyModuleInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" /&gt;
3333
&lt;CodeInspection Name="LineLabelNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
3434
&lt;CodeInspection Name="IntegerDataTypeInspection" Severity="Hint" InspectionType="CodeQualityIssues" /&gt;
3535
&lt;CodeInspection Name="ShadowedDeclarationInspection" Severity="DoNotShow" InspectionType="CodeQualityIssues" /&gt;
3636
&lt;CodeInspection Name="ConstantNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
37-
&lt;CodeInspection Name="DefaultProjectNameInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
38-
&lt;CodeInspection Name="EmptyCaseBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
39-
&lt;CodeInspection Name="EmptyDoWhileBlockInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
40-
&lt;CodeInspection Name="EmptyElseBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
41-
&lt;CodeInspection Name="EmptyForEachBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
42-
&lt;CodeInspection Name="EmptyForLoopBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
43-
&lt;CodeInspection Name="EmptyIfBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
44-
&lt;CodeInspection Name="EmptyWhileWendBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
45-
&lt;CodeInspection Name="EncapsulatePublicFieldInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
37+
&lt;CodeInspection Name="DefaultProjectNameInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
38+
&lt;CodeInspection Name="EmptyCaseBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
39+
&lt;CodeInspection Name="EmptyDoWhileBlockInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
40+
&lt;CodeInspection Name="EmptyElseBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
41+
&lt;CodeInspection Name="EmptyForEachBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
42+
&lt;CodeInspection Name="EmptyForLoopBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
43+
&lt;CodeInspection Name="EmptyIfBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
44+
&lt;CodeInspection Name="EmptyWhileWendBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
45+
&lt;CodeInspection Name="EncapsulatePublicFieldInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
4646
&lt;CodeInspection Name="HostSpecificExpressionInspection" Severity="Warning" InspectionType="LanguageOpportunities" /&gt;
47-
&lt;CodeInspection Name="HungarianNotationInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
47+
&lt;CodeInspection Name="HungarianNotationInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
4848
&lt;CodeInspection Name="ImplicitActiveSheetReferenceInspection" Severity="Warning" InspectionType="LanguageOpportunities" /&gt;
4949
&lt;CodeInspection Name="ImplicitActiveWorkbookReferenceInspection" Severity="Warning" InspectionType="LanguageOpportunities" /&gt;
5050
&lt;CodeInspection Name="ImplicitDefaultMemberAssignmentInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
5151
&lt;CodeInspection Name="ImplicitPublicMemberInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
5252
&lt;CodeInspection Name="ImplicitVariantReturnTypeInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
5353
&lt;CodeInspection Name="MemberNotOnInterfaceInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
54-
&lt;CodeInspection Name="MoveFieldCloserToUsageInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
54+
&lt;CodeInspection Name="MoveFieldCloserToUsageInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" /&gt;
5555
&lt;CodeInspection Name="NonReturningFunctionInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
5656
&lt;CodeInspection Name="ObjectVariableNotSetInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
5757
&lt;CodeInspection Name="ObsoleteGlobalInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
5858
&lt;CodeInspection Name="ObsoleteTypeHintInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
59-
&lt;CodeInspection Name="ParameterCanBeByValInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
59+
&lt;CodeInspection Name="ParameterCanBeByValInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
6060
&lt;CodeInspection Name="ParameterNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
6161
&lt;CodeInspection Name="ProcedureNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
6262
&lt;CodeInspection Name="SelfAssignedDeclarationInspection" Severity="Suggestion" InspectionType="CodeQualityIssues" /&gt;
6363
&lt;CodeInspection Name="UnassignedVariableUsageInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
6464
&lt;CodeInspection Name="UndeclaredVariableInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
6565
&lt;CodeInspection Name="UntypedFunctionUsageInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
66-
&lt;CodeInspection Name="UseMeaningfulNameInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
66+
&lt;CodeInspection Name="UseMeaningfulNameInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
6767
&lt;CodeInspection Name="VariableNotAssignedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
6868
&lt;CodeInspection Name="VariableNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
6969
&lt;CodeInspection Name="VariableTypeNotDeclaredInspection" Severity="Warning" InspectionType="LanguageOpportunities" /&gt;
@@ -72,7 +72,7 @@
7272
&lt;CodeInspection Name="StepIsNotSpecifiedInspection" Severity="DoNotShow" InspectionType="LanguageOpportunities" /&gt;
7373
&lt;CodeInspection Name="StepOneIsRedundantInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
7474
&lt;CodeInspection Name="SheetAccessedUsingStringInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
75-
&lt;CodeInspection Name="ObsoleteMemberUsageInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
75+
&lt;CodeInspection Name="ObsoleteMemberUsageInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
7676
&lt;CodeInspection Name="ObsoleteCallingConventionInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
7777
&lt;CodeInspection Name="DuplicatedAnnotationInspection" Severity="Error" InspectionType="RubberduckOpportunities" /&gt;
7878
&lt;CodeInspection Name="ModuleWithoutFolderInspection" Severity="Suggestion" InspectionType="RubberduckOpportunities" /&gt;

‎Rubberduck.CodeAnalysis/app.config‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
xmlns:xsd="http://www.w3.org/2001/XMLSchema">
2323
<CodeInspections>
2424
<CodeInspection Name="BooleanAssignedInIfElseInspection" Severity="Warning"
25-
InspectionType="MaintainabilityAndReadabilityIssues" />
25+
InspectionType="NamingAndConventionsIssues" />
2626
<CodeInspection Name="ObsoleteErrorSyntaxInspection" Severity="Suggestion"
2727
InspectionType="LanguageOpportunities" />
2828
<CodeInspection Name="StopKeywordInspection" Severity="Suggestion"
@@ -46,16 +46,16 @@
4646
<CodeInspection Name="ModuleScopeDimKeywordInspection" Severity="Suggestion"
4747
InspectionType="LanguageOpportunities" />
4848
<CodeInspection Name="MultilineParameterInspection" Severity="Suggestion"
49-
InspectionType="MaintainabilityAndReadabilityIssues" />
49+
InspectionType="NamingAndConventionsIssues" />
5050
<CodeInspection Name="MultipleDeclarationsInspection" Severity="Warning"
51-
InspectionType="MaintainabilityAndReadabilityIssues" />
51+
InspectionType="NamingAndConventionsIssues" />
5252
<CodeInspection Name="ObsoleteCallStatementInspection" Severity="Suggestion"
5353
InspectionType="LanguageOpportunities" />
5454
<CodeInspection Name="ObsoleteCommentSyntaxInspection" Severity="Suggestion"
5555
InspectionType="LanguageOpportunities" />
5656
<CodeInspection Name="ObsoleteLetStatementInspection" Severity="Suggestion"
5757
InspectionType="LanguageOpportunities" />
58-
<CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" />
58+
<CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" />
5959
<CodeInspection Name="RedundantOptionInspection" Severity="Hint"
6060
InspectionType="LanguageOpportunities" />
6161
<CodeInspection Name="OptionExplicitInspection" Severity="Error"
@@ -67,7 +67,7 @@
6767
<CodeInspection Name="AssignedByValParameterInspection" Severity="Warning"
6868
InspectionType="CodeQualityIssues" />
6969
<CodeInspection Name="EmptyModuleInspection" Severity="Hint"
70-
InspectionType="MaintainabilityAndReadabilityIssues" />
70+
InspectionType="NamingAndConventionsIssues" />
7171
<CodeInspection Name="LineLabelNotUsedInspection" Severity="Warning"
7272
InspectionType="CodeQualityIssues" />
7373
<CodeInspection Name="IntegerDataTypeInspection" Severity="Hint"
@@ -77,27 +77,27 @@
7777
<CodeInspection Name="ConstantNotUsedInspection" Severity="Warning"
7878
InspectionType="CodeQualityIssues" />
7979
<CodeInspection Name="DefaultProjectNameInspection" Severity="Suggestion"
80-
InspectionType="MaintainabilityAndReadabilityIssues" />
80+
InspectionType="NamingAndConventionsIssues" />
8181
<CodeInspection Name="EmptyCaseBlockInspection" Severity="Warning"
82-
InspectionType="MaintainabilityAndReadabilityIssues" />
82+
InspectionType="NamingAndConventionsIssues" />
8383
<CodeInspection Name="EmptyDoWhileBlockInspection" Severity="Suggestion"
84-
InspectionType="MaintainabilityAndReadabilityIssues" />
84+
InspectionType="NamingAndConventionsIssues" />
8585
<CodeInspection Name="EmptyElseBlockInspection" Severity="Warning"
86-
InspectionType="MaintainabilityAndReadabilityIssues" />
86+
InspectionType="NamingAndConventionsIssues" />
8787
<CodeInspection Name="EmptyForEachBlockInspection" Severity="Warning"
88-
InspectionType="MaintainabilityAndReadabilityIssues" />
88+
InspectionType="NamingAndConventionsIssues" />
8989
<CodeInspection Name="EmptyForLoopBlockInspection" Severity="Warning"
90-
InspectionType="MaintainabilityAndReadabilityIssues" />
90+
InspectionType="NamingAndConventionsIssues" />
9191
<CodeInspection Name="EmptyIfBlockInspection" Severity="Warning"
92-
InspectionType="MaintainabilityAndReadabilityIssues" />
92+
InspectionType="NamingAndConventionsIssues" />
9393
<CodeInspection Name="EmptyWhileWendBlockInspection" Severity="Warning"
94-
InspectionType="MaintainabilityAndReadabilityIssues" />
94+
InspectionType="NamingAndConventionsIssues" />
9595
<CodeInspection Name="EncapsulatePublicFieldInspection" Severity="Suggestion"
96-
InspectionType="MaintainabilityAndReadabilityIssues" />
96+
InspectionType="NamingAndConventionsIssues" />
9797
<CodeInspection Name="HostSpecificExpressionInspection" Severity="Warning"
9898
InspectionType="LanguageOpportunities" />
9999
<CodeInspection Name="HungarianNotationInspection" Severity="Suggestion"
100-
InspectionType="MaintainabilityAndReadabilityIssues" />
100+
InspectionType="NamingAndConventionsIssues" />
101101
<CodeInspection Name="ImplicitActiveSheetReferenceInspection"
102102
Severity="Warning" InspectionType="LanguageOpportunities" />
103103
<CodeInspection Name="ImplicitActiveWorkbookReferenceInspection"
@@ -111,7 +111,7 @@
111111
<CodeInspection Name="MemberNotOnInterfaceInspection" Severity="Warning"
112112
InspectionType="CodeQualityIssues" />
113113
<CodeInspection Name="MoveFieldCloserToUsageInspection" Severity="Hint"
114-
InspectionType="MaintainabilityAndReadabilityIssues" />
114+
InspectionType="NamingAndConventionsIssues" />
115115
<CodeInspection Name="NonReturningFunctionInspection" Severity="Error"
116116
InspectionType="CodeQualityIssues" />
117117
<CodeInspection Name="ObjectVariableNotSetInspection" Severity="Error"
@@ -121,7 +121,7 @@
121121
<CodeInspection Name="ObsoleteTypeHintInspection" Severity="Suggestion"
122122
InspectionType="LanguageOpportunities" />
123123
<CodeInspection Name="ParameterCanBeByValInspection" Severity="Suggestion"
124-
InspectionType="MaintainabilityAndReadabilityIssues" />
124+
InspectionType="NamingAndConventionsIssues" />
125125
<CodeInspection Name="ParameterNotUsedInspection" Severity="Warning"
126126
InspectionType="CodeQualityIssues" />
127127
<CodeInspection Name="ProcedureNotUsedInspection" Severity="Warning"
@@ -135,7 +135,7 @@
135135
<CodeInspection Name="UntypedFunctionUsageInspection" Severity="Hint"
136136
InspectionType="LanguageOpportunities" />
137137
<CodeInspection Name="UseMeaningfulNameInspection" Severity="Suggestion"
138-
InspectionType="MaintainabilityAndReadabilityIssues" />
138+
InspectionType="NamingAndConventionsIssues" />
139139
<CodeInspection Name="VariableNotAssignedInspection" Severity="Warning"
140140
InspectionType="CodeQualityIssues" />
141141
<CodeInspection Name="VariableNotUsedInspection" Severity="Warning"
@@ -153,7 +153,7 @@
153153
<CodeInspection Name="SheetAccessedUsingStringInspection" Severity="Suggestion"
154154
InspectionType="LanguageOpportunities" />
155155
<CodeInspection Name="ObsoleteMemberUsageInspection" Severity="Warning"
156-
InspectionType="MaintainabilityAndReadabilityIssues" />
156+
InspectionType="NamingAndConventionsIssues" />
157157
<CodeInspection Name="ObsoleteCallingConventionInspection" Severity="Warning"
158158
InspectionType="CodeQualityIssues" />
159159
<CodeInspection Name="DuplicatedAnnotationInspection" Severity="Error"

0 commit comments

Comments
 (0)