Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azimuth usage in getRangeCircle() #133

Open
Raviu56 opened this issue May 17, 2024 · 1 comment
Open

azimuth usage in getRangeCircle() #133

Raviu56 opened this issue May 17, 2024 · 1 comment

Comments

@Raviu56
Copy link

Raviu56 commented May 17, 2024

For azimuth in getRangeCircle() under class SatPos
This line val rads = azimuth * DEG2RAD converts it to RAD while everything in SatPos in already in radians.
A hint should be added to the class, or a rename of variables to indicate that everything here is in radians. This also applies to devel branch where the class is now renamed to OrbitalPos

@rt-bishop
Copy link
Owner

Hey there! Thanks so much for this suggestion. The actual position calculation code was taken as is from predict4java only converted from java into kotlin. Currently I don't have time to keep on working on this project as I've recently became a daddy. Once things stabilize, my daughter grows up a bit and I finally get some sleep which I assume will happen in a few months I'll get back to the project with the intention to finish the miration to Compose UI. A lot of code has been refactored in devel branch and I do have plans to continue cleaning things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants